From: Neil Horman <nhorman@tuxdriver.com>
To: Anton Blanchard <anton@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Scott Wood <scottwood@freescale.com>,
Paul Mackerras <paulus@samba.org>,
Rusty Russell <rusty@rustcorp.com.au>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] module: ppc64 module CRC relocation fix causes perf issues
Date: Fri, 26 Jul 2013 09:11:14 -0400 [thread overview]
Message-ID: <20130726131114.GA11633@hmsreliant.think-freely.org> (raw)
In-Reply-To: <20130726111913.201ab9d4@kryten>
On Fri, Jul 26, 2013 at 11:19:13AM +1000, Anton Blanchard wrote:
>
> Hi Neil,
>
> > Sorry I'm a bit late to the thread, I've ben swamped. Has someone
> > tested this with kexec/kdump? Thats why the origional patch was
> > created, because when kexec loads the kernel at a different physical
> > address, the relocations messed with the module crc's, and modules
> > couldn't load during the kexec boot. Assuming that kernaddr_start
> > gets set appropriately during boot, using PHYSICAL_START should be
> > fine, but I wanted to check, and don't currently have access to a
> > powerpc system to do so. Neil
>
> I tested a relocatable kernel forced to run at a non zero physical
> address (ie basically kdump). I verified CRCs were bad with your
> original patch backed out, and were good with this patch applied.
>
> Anton
>
Perfect, sounds like a sufficient test to me.
Acked-by: Neil Horman <nhorman@tuxdriver.com>
prev parent reply other threads:[~2013-07-26 13:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 4:04 Anton Blanchard
2013-07-15 4:39 ` Rusty Russell
2013-07-15 8:47 ` Benjamin Herrenschmidt
2013-07-16 22:40 ` Scott Wood
2013-07-17 0:04 ` Benjamin Herrenschmidt
2013-07-17 0:08 ` Scott Wood
2013-07-18 4:00 ` Anton Blanchard
2013-07-19 22:59 ` Scott Wood
2013-07-23 13:30 ` Michael Ellerman
2013-07-24 19:22 ` Scott Wood
2013-07-24 22:34 ` Anton Blanchard
2013-07-24 23:14 ` Benjamin Herrenschmidt
2013-07-25 13:02 ` Neil Horman
2013-07-26 1:19 ` Anton Blanchard
2013-07-26 13:11 ` Neil Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726131114.GA11633@hmsreliant.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=anton@samba.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=rusty@rustcorp.com.au \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®