mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	Shuah Khan <shuah.kh@samsung.com>,
	Konstantin Khlebnikov <khlebnikov@openvz.org>
Subject: Re: [char-misc 3.11 V2] mei: me: fix hardware reset flow
Date: Tue, 30 Jul 2013 07:22:09 -0700	[thread overview]
Message-ID: <20130730142209.GA28956@kroah.com> (raw)
In-Reply-To: <1375182711-10253-1-git-send-email-tomas.winkler@intel.com>

On Tue, Jul 30, 2013 at 02:11:51PM +0300, Tomas Winkler wrote:
> Both H_IS and H_IE needs to be set to receive H_RDY 
> interrupt
> 
> 1. Assert H_IS to clear the interrupts during hw reset
> and use mei_me_reg_write instead of mei_hcsr_set as the later
> strips down the H_IS
> 
> 2. fix interrupt disablement embarrassing typo
>   hcsr |= ~H_IE -> hcsr &= ~H_IE;
> this will remove the unwanted interrupt on power down
> 
> 3. remove useless debug print outs
> 
> Cc: Shuah Khan <shuah.kh@samsung.com>
> Cc: Konstantin Khlebnikov <khlebnikov@openvz.org>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
> 
> V2: Fixed typo in Shuah email
> 
> Hope this finally resolve the ME reset issue for all

Can I get a "Tested-by:" from someone to ensure that it really does
solve the problem?

thanks,

greg k-h

  reply	other threads:[~2013-07-30 14:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-30 11:11 Tomas Winkler
2013-07-30 14:22 ` Greg KH [this message]
2013-07-30 14:27   ` Shuah Khan
2013-07-30 14:28   ` Winkler, Tomas
2013-07-30 19:04     ` Shuah Khan
2013-07-30 19:30       ` Winkler, Tomas
2013-07-31 15:51         ` Shuah Khan
2013-07-31 16:01           ` Winkler, Tomas
2013-07-31 17:15             ` Shuah Khan
2013-08-05  5:27     ` Greg KH
2013-08-05  5:55       ` Winkler, Tomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130730142209.GA28956@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=khlebnikov@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shuah.kh@samsung.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®