mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	ffainelli@freebox.fr, bigeasy@linutronix.de,
	paul.gortmaker@windriver.com, akpm@linux-foundation.org,
	yongjun_wei@trendmicro.com.cn, x86@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] x86: ce4100: remove duplicated include from ce4100.c
Date: Tue, 30 Jul 2013 20:56:09 +0200	[thread overview]
Message-ID: <20130730185609.GB21687@gmail.com> (raw)
In-Reply-To: <CAPgLHd_SnM4M-OZ5hX-vRpvjcm4=i-LiNgTTvwQmHhmOdsaPeg@mail.gmail.com>


* Wei Yongjun <weiyj.lk@gmail.com> wrote:

> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Remove duplicated include.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
>  arch/x86/platform/ce4100/ce4100.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/x86/platform/ce4100/ce4100.c b/arch/x86/platform/ce4100/ce4100.c
> index 8244f5e..d62e74d 100644
> --- a/arch/x86/platform/ce4100/ce4100.c
> +++ b/arch/x86/platform/ce4100/ce4100.c
> @@ -15,7 +15,6 @@
>  #include <linux/reboot.h>
>  #include <linux/serial_reg.h>
>  #include <linux/serial_8250.h>
> -#include <linux/reboot.h>
>  
>  #include <asm/ce4100.h>
>  #include <asm/prom.h>

Hm, while at it, this file could need more cleanups:

 - nonstandard comments
 - various checkpatch complaints that seem legit
 - col80 limits were 'solved' using ugly linebreaks

Thanks,

	Ingo

  reply	other threads:[~2013-07-30 18:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-29  4:27 Wei Yongjun
2013-07-30 18:56 ` Ingo Molnar [this message]
2016-07-19 12:02 [PATCH -next] x86: ce4100: Remove " Wei Yongjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130730185609.GB21687@gmail.com \
    --to=mingo@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bigeasy@linutronix.de \
    --cc=ffainelli@freebox.fr \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=tglx@linutronix.de \
    --cc=weiyj.lk@gmail.com \
    --cc=x86@kernel.org \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®