From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: linux-kernel@vger.kernel.org, Michal Simek <monstr@monstr.eu>,
Al Viro <viro@ZenIV.linux.org.uk>,
dholsgrove@xilinx.com, Rich Felker <dalias@aerifal.cx>,
Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
James Hogan <james.hogan@imgtec.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Kees Cook <keescook@chromium.org>,
Oleg Nesterov <oleg@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
microblaze-uclinux@itee.uq.edu.au
Subject: Re: [PATCH v3] microblaze: Fix clone syscall
Date: Wed, 31 Jul 2013 13:10:30 -0700 [thread overview]
Message-ID: <20130731131030.3d03c68362382dad78136cfb@linux-foundation.org> (raw)
In-Reply-To: <db3f4687983a591b1797f2a54a9a8eb695afb9ac.1375081274.git.michal.simek@xilinx.com>
On Mon, 29 Jul 2013 09:01:48 +0200 Michal Simek <michal.simek@xilinx.com> wrote:
> Fix inadvertent breakage in the clone syscall ABI for Microblaze
> that was introduced in this patch:
> "microblaze: switch to generic fork/vfork/clone"
> (sha1: f3268edbe6fe0ce56e62c6d6b14640aeb04864b7)
>
> The Microblaze syscall ABI for clone takes the parent tid address in
> the 4th argument; the third argument slot is used for the stack size.
> The incorrectly-used CLONE_BACKWARDS type assigned parent tid to the
> 3rd slot.
>
> This commit restores the original ABI so that existing userspace libc
> code will work correctly.
>
> All kernel versions from v3.8-rc1 were affected.
x86_64 allnoconfig generates screenfuls of
In file included from fs/signalfd.c:31:
include/linux/syscalls.h:805:5: warning: "CONFIG_CLONE_BACKWARDS3" is not defined
> --- a/include/linux/syscalls.h
> +++ b/include/linux/syscalls.h
> @@ -802,9 +802,14 @@ asmlinkage long sys_vfork(void);
> asmlinkage long sys_clone(unsigned long, unsigned long, int __user *, int,
> int __user *);
> #else
> +#if CONFIG_CLONE_BACKWARDS3
Presumably ifdef here will fix that. Please redo, retest and resend?
next prev parent reply other threads:[~2013-07-31 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 7:01 Michal Simek
2013-07-31 20:10 ` Andrew Morton [this message]
2013-08-01 7:58 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731131030.3d03c68362382dad78136cfb@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dalias@aerifal.cx \
--cc=dholsgrove@xilinx.com \
--cc=ebiederm@xmission.com \
--cc=fweisbec@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
--cc=oleg@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=srikar@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®