From: Lee Jones <lee.jones@linaro.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Samuel Ortiz'" <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Thomas Abraham <thomas.abraham@linaro.org>
Subject: Re: [PATCH] mfd: max8997: cast void pointer to data of max8997_pmic_dt_match
Date: Thu, 1 Aug 2013 09:52:21 +0100 [thread overview]
Message-ID: <20130801085221.GN13298@lee--X1> (raw)
In-Reply-To: <002e01ce8e5b$08700410$19500c30$@samsung.com>
On Thu, 01 Aug 2013, Jingoo Han wrote:
> Casting (void *) data of max8997_pmic_dt_match is necessary,
> because variable 'data' of struct 'of_device_id' is defined as
> 'const void *data'. Thus, pointer should be used instead of value.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mfd/max8997.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c
> index 1471405..e6d668a 100644
> --- a/drivers/mfd/max8997.c
> +++ b/drivers/mfd/max8997.c
> @@ -51,7 +51,7 @@ static struct mfd_cell max8997_devs[] = {
>
> #ifdef CONFIG_OF
> static struct of_device_id max8997_pmic_dt_match[] = {
> - { .compatible = "maxim,max8997-pmic", .data = TYPE_MAX8997 },
> + { .compatible = "maxim,max8997-pmic", .data = (void *)TYPE_MAX8997 },
> {},
> };
> #endif
Applied, thanks.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2013-08-01 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 2:01 Jingoo Han
2013-08-01 8:52 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801085221.GN13298@lee--X1 \
--to=lee.jones@linaro.org \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sameo@linux.intel.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome