From: Tejun Heo <tj@kernel.org>
To: Li Zefan <lizefan@huawei.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Cgroups <cgroups@vger.kernel.org>
Subject: Re: [PATCH v2 3/7] cgroup: restructure the failure path in cgroup_write_event_control()
Date: Thu, 1 Aug 2013 09:30:22 -0400 [thread overview]
Message-ID: <20130801133022.GD24966@htj.dyndns.org> (raw)
In-Reply-To: <51F9BF33.4060306@huawei.com>
On Thu, Aug 01, 2013 at 09:51:47AM +0800, Li Zefan wrote:
> It uses a single label and checks the validity of each pointer. This
> is err-prone, and actually we had a bug because one of the check was
> insufficient.
>
> Use multi lables as we do in other places.
>
> v2:
> - drop initializations of local variables.
>
> Signed-off-by: Li Zefan <lizefan@huawei.com>
Applied to cgroup/for-3.12.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-08-01 13:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 8:16 [PATCH 0/7] some pending cgroup patches Li Zefan
2013-07-31 8:16 ` [PATCH 1/7] cgroup: fix a leak when percpu_ref_init() fails Li Zefan
2013-07-31 10:14 ` Tejun Heo
2013-07-31 8:16 ` [PATCH 2/7] cgroup: remove sparse tags from offline_css() Li Zefan
2013-07-31 10:42 ` Tejun Heo
2013-07-31 8:17 ` [PATCH 3/7] cgroup: restructure the failure path in cgroup_write_event_control() Li Zefan
2013-07-31 10:44 ` Tejun Heo
2013-08-01 1:51 ` [PATCH v2 " Li Zefan
2013-08-01 13:30 ` Tejun Heo [this message]
2013-07-31 8:17 ` [PATCH 4/7] cgroup: rename cgroup_pidlist->mutex Li Zefan
2013-07-31 11:35 ` Tejun Heo
2013-08-01 1:52 ` [PATCH v2 " Li Zefan
2013-08-01 13:30 ` Tejun Heo
2013-07-31 8:17 ` [PATCH 5/7] cgroup: remove struct cgroup_seqfile_state Li Zefan
2013-07-31 9:27 ` Li Zefan
2013-07-31 11:35 ` Tejun Heo
2013-08-01 1:11 ` Li Zefan
2013-07-31 8:18 ` [PATCH 6/7] cgroup: rename current_css_set_cg_links Li Zefan
2013-07-31 11:38 ` Tejun Heo
2013-08-01 1:11 ` Li Zefan
2013-07-31 8:18 ` [PATCH 7/7] cgroup: more naming cleanups Li Zefan
2013-07-31 11:39 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801133022.GD24966@htj.dyndns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome