From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: lgirdwood@gmail.com, tiwai@suse.de, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: core: init delayed_work for codec-codec links
Date: Fri, 2 Aug 2013 11:14:54 +0100 [thread overview]
Message-ID: <20130802101454.GI9858@sirena.org.uk> (raw)
In-Reply-To: <20130802100108.GA17936@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
On Fri, Aug 02, 2013 at 11:01:08AM +0100, Richard Fitzgerald wrote:
> +static void codec2codec_close_delayed_work(struct work_struct *work)
> +{
> + /* No action required.
> + * C2C links only represent a hardware connection and currently
> + * we assume that we don't have to explicitly start or stop them
> + */
> +}
That's not the reason - what's happening with the stream events is that
since these links are not on the edge of the DAPM graph we don't need to
interface with the outside world. Further since we're not dealing with
the application layer there is no need to delay the power down, the
reason that's there is to stop us powering the link down if there's just
a small gap between tracks so we don't get pops, clicks and extra gaps
if the application layer is closing the device at the end of every track
(which is quite a common pattern).
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-02 10:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 13:16 [PATCH] " Richard Fitzgerald
2013-07-31 13:25 ` Mark Brown
2013-08-01 15:13 ` Richard Fitzgerald
2013-08-01 15:23 ` Mark Brown
2013-08-01 15:50 ` Richard Fitzgerald
2013-08-01 18:47 ` Mark Brown
2013-08-02 10:01 ` [PATCH v2] " Richard Fitzgerald
2013-08-02 10:14 ` Mark Brown [this message]
2013-08-02 10:51 ` [alsa-devel] [PATCH v3] " Richard Fitzgerald
2013-08-05 10:33 ` Mark Brown
2013-08-05 12:17 ` [alsa-devel] [PATCH v4] " Richard Fitzgerald
2013-08-05 16:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802101454.GI9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rf@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®