From: David Miller <davem@davemloft.net>
To: hpa@zytor.com
Cc: dh.herrmann@gmail.com, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, plagnioj@jcrosoft.com,
tomi.valkeinen@ti.com, santiago@crfreenet.org
Subject: Re: [PATCH] fbdev: suppress warning when assigning vga-save/restore base
Date: Sun, 04 Aug 2013 18:51:46 -0700 (PDT) [thread overview]
Message-ID: <20130804.185146.1621476659301936865.davem@davemloft.net> (raw)
In-Reply-To: <51FE907A.2090201@zytor.com>
From: "H. Peter Anvin" <hpa@zytor.com>
Date: Sun, 04 Aug 2013 10:33:46 -0700
> Anyone who can dig backwards and summarize? In other words:
>
> Where in the current code do we stuff a physical address in a pointer,
> or a virtual address into a non-pointer?
The VGA register accessors try to accomodate iomem and ioport
accesses.
If they are given a non-NULL iomem pointer 'regbase' they use
iomem accesses, otherwise they do direct ISA port poking.
And yes the drivers in question are making some brash assumptions.
I suspect they should be using ioremap() or similar.
next prev parent reply other threads:[~2013-08-05 1:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-04 17:25 David Herrmann
2013-08-04 17:33 ` H. Peter Anvin
2013-08-05 1:51 ` David Miller [this message]
2013-08-05 20:29 ` Ondrej Zajicek
2013-08-05 21:02 ` H. Peter Anvin
2013-08-05 21:14 ` H. Peter Anvin
2013-08-05 22:29 ` David Miller
2014-02-10 11:23 ` Tomi Valkeinen
2014-02-10 11:32 ` David Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130804.185146.1621476659301936865.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dh.herrmann@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=santiago@crfreenet.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®