From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753354Ab3HDBo1 (ORCPT ); Sat, 3 Aug 2013 21:44:27 -0400 Received: from imap.thunk.org ([74.207.234.97]:39067 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753233Ab3HDBoZ (ORCPT ); Sat, 3 Aug 2013 21:44:25 -0400 Date: Sat, 3 Aug 2013 20:49:04 -0400 From: "Theodore Ts'o" To: Nitin Singla Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Manish Sharma , kapil upadhayay Subject: Re: [PATCH 1/1] EXT4: LazyInit Mount Bug Fix Message-ID: <20130804004904.GB19781@thunk.org> Mail-Followup-To: Theodore Ts'o , Nitin Singla , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Manish Sharma , kapil upadhayay References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 15, 2013 at 12:14:18PM +0530, Nitin Singla wrote: > - sbi->s_itb_per_group = sbi->s_inodes_per_group / > - sbi->s_inodes_per_block; > + sbi->s_itb_per_group = DIV_ROUND_UP(sbi->s_inodes_per_group, > + sbi->s_inodes_per_block); This would only matter if s_inodes_per_group is not a multiple of s_inodes_per_block. Which is never supposed to happen; mke2fs doesn't create file systems like this. Ancient Android build systems, before the bug was fixed, did do this in the past, but that was a long time ago. Where did this file system come from? I could apply this patch, but you should be warned that there may be other bugs hiding here for file systems like this, both in the kernel and in e2fsprogs. - Ted