From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/9] perf tools: Enhance and correct srcline behavior
Date: Tue, 6 Aug 2013 13:54:40 +0200 [thread overview]
Message-ID: <20130806115440.GA1068@krava.brq.redhat.com> (raw)
In-Reply-To: <1375325744-26613-1-git-send-email-namhyung@kernel.org>
On Thu, Aug 01, 2013 at 11:55:35AM +0900, Namhyung Kim wrote:
> Hello,
>
> This patchset tries to fix and enhance current srcline behavior.
>
> Firstly it doesn't actually sort by srcline info but by ip. I suspect
> it was because of a performance reason to run external addr2line
> utility. It showed the srcline info after hist entries were
> collapsed. Thanks to Roberto, we now have internal implementation of
> addr2line using libbfd so can sort/compare by srcline of entries.
>
> Second problem for me was it sometimes printed "??:0" and sometimes
> printed a raw ip value for unknown srcline info. I changed to print
> the former consistently.
>
> While at it, I found some bugs/leaks in srcline handling. Patch 1-3
> are fixes for those and can be merged separately.
>
> You can get this series on my 'perf/srcline-v1' branch in my tree at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
>
> Any comments are welcome, thanks.
> Namhyung
>
>
> Namhyung Kim (8):
> perf sort: Fix a memory leak on srcline
> perf annotate: Reuse path from the result of addr2line
> perf hists: Free srcline when freeing hist_entry
> perf tools: Factor out get/free_srcline()
> perf tools: Do not try to call addr2line for non-binary files
> perf tools: Pass dso instead of dso_name to get_srcline()
> perf tools: Save failed result of get_srcline()
> perf tools: Fix srcline sort key behavior
>
> Roberto Vitillo (1):
> perf tools: Implement addr2line directly using libbfd
>
nice..
Reviewed-by: Jiri Olsa <jolsa@redhat.com>
prev parent reply other threads:[~2013-08-06 11:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 2:55 Namhyung Kim
2013-08-01 2:55 ` [PATCH 1/9] perf sort: Fix a memory leak on srcline Namhyung Kim
2013-08-01 2:55 ` [PATCH 2/9] perf annotate: Reuse path from the result of addr2line Namhyung Kim
2013-08-01 2:55 ` [PATCH 3/9] perf hists: Free srcline when freeing hist_entry Namhyung Kim
2013-08-01 2:55 ` [PATCH 4/9] perf tools: Factor out get/free_srcline() Namhyung Kim
2013-08-01 2:55 ` [PATCH 5/9] perf tools: Do not try to call addr2line for non-binary files Namhyung Kim
2013-08-01 2:55 ` [PATCH 6/9] perf tools: Pass dso instead of dso_name to get_srcline() Namhyung Kim
2013-08-01 2:55 ` [PATCH 7/9] perf tools: Save failed result of get_srcline() Namhyung Kim
2013-08-01 2:55 ` [PATCH 8/9] perf tools: Implement addr2line directly using libbfd Namhyung Kim
2013-08-01 2:55 ` [PATCH 9/9] perf tools: Fix srcline sort key behavior Namhyung Kim
2013-08-01 8:17 ` [PATCH 0/9] perf tools: Enhance and correct srcline behavior Peter Zijlstra
2013-08-06 11:54 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130806115440.GA1068@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®