From: Michael Ellerman <michael@ellerman.id.au>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, acme@ghostprotocols.net,
a.p.zijlstra@chello.nl
Subject: Re: [PATCH v2 1/2] perf tools: Add support for pinned modifier
Date: Wed, 7 Aug 2013 15:19:57 +1000 [thread overview]
Message-ID: <20130807051957.GC19998@concordia> (raw)
In-Reply-To: <20130806135937.GB1068@krava.brq.redhat.com>
On Tue, Aug 06, 2013 at 03:59:37PM +0200, Jiri Olsa wrote:
> On Tue, Aug 06, 2013 at 11:28:05PM +1000, Michael Ellerman wrote:
>
> SNIP
>
> >
> > while (*p) {
> > @@ -812,6 +818,9 @@ int parse_events__modifier_event(struct list_head *list, char *str, bool add)
> > evsel->attr.exclude_guest = mod.eG;
> > evsel->exclude_GH = mod.exclude_GH;
> > evsel->sample_read = mod.sample_read;
> > +
> > + if (evsel->leader == evsel)
> > + evsel->attr.pinned = mod.pinned;
>
> nitpick, we have perf_evsel__is_group_leader for this check
Ah darn, missed it.
Should I do a respin?
cheers
next prev parent reply other threads:[~2013-08-07 5:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 13:28 Michael Ellerman
2013-08-06 13:28 ` [PATCH v2 2/2] perf tests: Add tests of new " Michael Ellerman
2013-08-06 13:59 ` Jiri Olsa
2013-08-07 6:18 ` Namhyung Kim
2013-08-12 10:24 ` [tip:perf/core] " tip-bot for Michael Ellerman
2013-08-06 13:59 ` [PATCH v2 1/2] perf tools: Add support for " Jiri Olsa
2013-08-07 5:19 ` Michael Ellerman [this message]
2013-08-07 20:16 ` Arnaldo Carvalho de Melo
2013-08-07 21:33 ` Michael Ellerman
2013-08-06 14:02 ` Jiri Olsa
2013-08-07 6:18 ` Namhyung Kim
2013-08-12 10:23 ` [tip:perf/core] " tip-bot for Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807051957.GC19998@concordia \
--to=michael@ellerman.id.au \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®