From: Wolfram Sang <wsa@the-dreams.de>
To: Chew Chiau Ee <chiaue.ee.chew@intel.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c-designware: Manually set RESTART bit between messages
Date: Wed, 7 Aug 2013 16:28:47 +0200 [thread overview]
Message-ID: <20130807142847.GC2978@katana> (raw)
In-Reply-To: <1371798328-31931-1-git-send-email-chiaue.ee.chew@intel.com>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
On Fri, Jun 21, 2013 at 03:05:28PM +0800, Chew Chiau Ee wrote:
> From: Chew, Chiau Ee <chiau.ee.chew@intel.com>
>
> If both IC_EMPTYFIFO_HOLD_MASTER_EN and IC_RESTART_EN are set to 1, the
> Designware I2C controller doesn't generate RESTART unless user specifically
> requests it by setting RESTART bit in IC_DATA_CMD register.
>
> Since IC_EMPTYFIFO_HOLD_MASTER_EN setting can't be detected from hardware
> register, we must always manually set the restart bit between messages.
>
> Signed-off-by: Chew, Chiau Ee <chiau.ee.chew@intel.com>
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-08-07 14:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-21 7:05 Chew Chiau Ee
2013-07-03 20:15 ` Wolfram Sang
2013-07-04 7:41 ` Mika Westerberg
2013-07-16 3:27 ` Chew, Chiau Ee
2013-08-07 14:28 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807142847.GC2978@katana \
--to=wsa@the-dreams.de \
--cc=chiaue.ee.chew@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®