From: Andrew Morton <akpm@linux-foundation.org>
To: David Daney <ddaney@caviumnetworks.com>
Cc: Gilad Ben-Yossef <gilad@benyossef.com>,
Christoph Lameter <cl@gentwo.org>,
David Daney <ddaney.cavm@gmail.com>,
<linux-kernel@vger.kernel.org>,
Chris Metcalf <cmetcalf@tilera.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] smp.c: Quit unconditionally enabling irqs in on_each_cpu_mask().
Date: Mon, 12 Aug 2013 15:16:32 -0700 [thread overview]
Message-ID: <20130812151632.c787db7072bc4d93b43c1066@linux-foundation.org> (raw)
In-Reply-To: <52054208.4040201@caviumnetworks.com>
On Fri, 9 Aug 2013 12:24:56 -0700 David Daney <ddaney@caviumnetworks.com> wrote:
> > otherwise the bugs
> > stemming from incorrect use can be tricky to catch.
> >
>
> ... all my patch does is allow on_each_cpu_mask() to be called with IRQs
> disabled if we are in Early Boot. This is already the case with
> smp_call_function(), smp_call_function_many() and on_each_cpu(). I am
> arguing that for the sake of consistency and the principle that function
> behavior shouldn't be surprising, that we make on_each_cpu_mask() work
> the same way.
Yup, the check in smp_call_function_many() will tell us if anyone calls
on_each_cpu_mask() with interrupts disabled any time after boot.
The whole early_boot_irqs_disabled thing is of course totally vile :(
prev parent reply other threads:[~2013-08-12 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 18:25 David Daney
2013-08-08 19:25 ` Christoph Lameter
2013-08-08 20:27 ` David Daney
2013-08-09 18:51 ` Gilad Ben-Yossef
2013-08-09 19:24 ` David Daney
2013-08-12 22:16 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130812151632.c787db7072bc4d93b43c1066@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=cl@gentwo.org \
--cc=cmetcalf@tilera.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=ddaney@caviumnetworks.com \
--cc=gilad@benyossef.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®