From: Andrew Morton <akpm@linux-foundation.org>
To: Sangjung Woo <sangjung.woo@samsung.com>
Cc: Jonghwa Lee <jonghwa3.lee@samsung.com>,
linux-kernel@vger.kernel.org,
Myugnjoo Ham <myungjoo.ham@samsung.com>
Subject: Re: [PATCH] drivers/rtc/rtc-max77686.c: Fix wrong register
Date: Wed, 14 Aug 2013 13:21:39 -0700 [thread overview]
Message-ID: <20130814132139.82b8c40e460845535190e1d0@linux-foundation.org> (raw)
In-Reply-To: <1376443301-969-1-git-send-email-sangjung.woo@samsung.com>
On Wed, 14 Aug 2013 10:21:41 +0900 Sangjung Woo <sangjung.woo@samsung.com> wrote:
> Fix to read the wrong register when checking whether the RTC timer has
> reached or not.
>
> ...
>
> --- a/drivers/rtc/rtc-max77686.c
> +++ b/drivers/rtc/rtc-max77686.c
> @@ -240,9 +240,9 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
> }
>
> alrm->pending = 0;
> - ret = regmap_read(info->max77686->regmap, MAX77686_REG_STATUS1, &val);
> + ret = regmap_read(info->max77686->regmap, MAX77686_REG_STATUS2, &val);
> if (ret < 0) {
> - dev_err(info->dev, "%s:%d fail to read status1 reg(%d)\n",
> + dev_err(info->dev, "%s:%d fail to read status2 reg(%d)\n",
> __func__, __LINE__, ret);
> goto out;
> }
The changelog didn't describe the end-user visible effects of the bug,
so I am unable to determine which kernel version(s) need patching.
Please always include this information.
next prev parent reply other threads:[~2013-08-14 20:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 1:21 Sangjung Woo
2013-08-14 20:21 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-13 13:37 Sangjung Woo
2013-08-13 14:33 ` jonghwa3.lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814132139.82b8c40e460845535190e1d0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jonghwa3.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=sangjung.woo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®