From: Mark Brown <broonie@kernel.org>
To: Ma Haijun <mahaijuns@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: wm8960: Fix shared LRCLK support
Date: Wed, 14 Aug 2013 19:22:12 +0100 [thread overview]
Message-ID: <20130814182212.GJ2401@sirena.org.uk> (raw)
In-Reply-To: <1376442946-2803-2-git-send-email-mahaijuns@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 394 bytes --]
On Wed, Aug 14, 2013 at 09:15:39AM +0800, Ma Haijun wrote:
> Shared LRCLK initialization does not survive wm8960_reset,
> so place it after the reset.
This is a bit odd - why is it a good idea to be doing a reset and
shouldn't there be a register cache sync to restore the setting anyway?
I'm not sure this is the right fix for the prolem, it could just be
fixing one aspect of a wider issue.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-08-14 18:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-14 1:15 Ma Haijun
2013-08-14 18:22 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814182212.GJ2401@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahaijuns@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®