From: "Philip J. Kelleher" <pjk1939@linux.vnet.ibm.com>
To: axboe@kernel.dk
Cc: linux-kernel@vger.kernel.org, brking@linux.vnet.ibm.com
Subject: [PATCH 4/5] rsxx: Removing IDA on driver unload.
Date: Wed, 14 Aug 2013 16:36:25 -0500 [thread overview]
Message-ID: <20130814213625.GE26562@oc6784271780.ibm.com> (raw)
From: Philip J Kelleher <pjk1939@linux.vnet.ibm.com>
The rsxx driver was not releasing the IDA entry during
driver unload. This would be a big problem on a DLPAR
remove where the card is remove from the LPAR but the
driver is still loaded. This patch fixes that issue.
Signed-off-by: Philip J Kelleher <pjk1939@linux.vnet.ibm.com>
-------------------------------------------------------------------------------
diff -uprN -X linux-block-vanilla/Documentation/dontdiff linux-block-vanilla/drivers/block/rsxx/core.c linux-block/drivers/block/rsxx/core.c
--- linux-block-vanilla/drivers/block/rsxx/core.c 2013-08-12 15:30:57.959857895 -0500
+++ linux-block/drivers/block/rsxx/core.c 2013-08-12 15:31:12.833861866 -0500
@@ -1101,6 +1101,10 @@ static void rsxx_pci_remove(struct pci_d
pci_disable_device(dev);
pci_release_regions(dev);
+ spin_lock(&rsxx_ida_lock);
+ ida_remove(&rsxx_disk_ida, card->disk_id);
+ spin_unlock(&rsxx_ida_lock);
+
kfree(card);
}
reply other threads:[~2013-08-14 21:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130814213625.GE26562@oc6784271780.ibm.com \
--to=pjk1939@linux.vnet.ibm.com \
--cc=axboe@kernel.dk \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®