From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751385Ab3HTNiH (ORCPT ); Tue, 20 Aug 2013 09:38:07 -0400 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:64201 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001Ab3HTNiE (ORCPT ); Tue, 20 Aug 2013 09:38:04 -0400 Date: Tue, 20 Aug 2013 14:37:33 +0100 From: Will Deacon To: Mark Salter Cc: linux-kernel , Catalin Marinas , linux-arm-kernel Subject: Re: [PATCH] arm64: add screen_info for console support Message-ID: <20130820133733.GF26129@mudshark.cambridge.arm.com> References: <1376842970.11104.11.camel@t520.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1376842970.11104.11.camel@t520.redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On Sun, Aug 18, 2013 at 05:22:50PM +0100, Mark Salter wrote: > The arm64 port doesn't provide a screen_info struct for console support > which leads to a build failure with some configurations: > > drivers/video/console/vgacon.c:820: undefined reference to `screen_info' > > This patch adds an empty declaration of screen_info to fix the build > problem. Some additional runtime code is needed to actually make it > useful. > > Signed-off-by: Mark Salter > --- > arch/arm64/kernel/setup.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > index add6ea6..eb9f93a 100644 > --- a/arch/arm64/kernel/setup.c > +++ b/arch/arm64/kernel/setup.c > @@ -64,6 +64,10 @@ static const char *cpu_name; > static const char *machine_name; > phys_addr_t __fdt_pointer __initdata; > > +#if defined(CONFIG_VGA_CONSOLE) || defined(CONFIG_DUMMY_CONSOLE) > +struct screen_info screen_info; > +#endif You may be able to do something similar to the proposal for PARPORT here and factor out the lengthy "depends on" clause for VGA_CONSOLE instead of adding the dummy info. Unfortunately, I can't make any promise of further bonus points :) Will