From: Mark Brown <broonie@kernel.org>
To: Michal Simek <monstr@monstr.eu>
Cc: Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org,
linux-spi <linux-spi@vger.kernel.org>,
Grant Likely <grant.likely@linaro.org>,
spi-devel-general@lists.sourceforge.net
Subject: Re: [PATCH v1 3/4] spi/xilinx: Simplify irq allocation
Date: Thu, 22 Aug 2013 14:10:51 +0100 [thread overview]
Message-ID: <20130822131051.GI26118@sirena.org.uk> (raw)
In-Reply-To: <51E00BF8.2020608@monstr.eu>
[-- Attachment #1: Type: text/plain, Size: 817 bytes --]
On Fri, Jul 12, 2013 at 04:00:24PM +0200, Michal Simek wrote:
> Just a follow up on this.
Sorry, this one fell through the cracks - apologies for the delay.
> Which function free private structures registered by spi_alloc_master function?
> Is it in spi_master_put()?
Yes, or spi_master_unregister() after it's been registered.
> The reason why I am asking is where clk_xx functions should be added.
> I see them between these two functions in sifr for example.
> And also I see in drivers in error probe path that drivers are calling kfree(master)
> but they are not doing in remove part (like spi-davinci.c).
> I just want to clear this in our zynq drivers before we send them out.
I'd not be surprised if there were errors in the error handling paths,
it's (hopefully!) not the best tested code out there.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-08-22 13:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 13:29 [PATCH v1 1/4] spi/xilinx: Remove CONFIG_OF from the driver Michal Simek
2013-07-08 13:29 ` [PATCH v1 2/4] spi/xilinx: Clean ioremap calling Michal Simek
2013-07-08 14:50 ` Mark Brown
2013-07-08 13:29 ` [PATCH v1 3/4] spi/xilinx: Simplify irq allocation Michal Simek
2013-07-08 14:49 ` Mark Brown
2013-07-08 15:48 ` Michal Simek
2013-07-08 16:26 ` Mark Brown
2013-07-09 14:15 ` Michal Simek
2013-07-09 14:47 ` Mark Brown
2013-07-09 14:53 ` Michal Simek
2013-07-12 14:00 ` Michal Simek
2013-08-22 13:10 ` Mark Brown [this message]
2013-07-08 13:29 ` [PATCH v1 4/4] spi/xilinx: Use of_property_read_u32 for reading value from node Michal Simek
2013-07-08 14:51 ` Mark Brown
2013-07-09 5:26 ` Michal Simek
2013-07-09 9:14 ` Mark Brown
2013-07-08 14:49 ` [PATCH v1 1/4] spi/xilinx: Remove CONFIG_OF from the driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822131051.GI26118@sirena.org.uk \
--to=broonie@kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®