From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: LKML <linux-kernel@vger.kernel.org>,
mhocko@suse.cz, hare@suse.de,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 0/4 v6] Avoid softlockups in console_unlock()
Date: Thu, 22 Aug 2013 15:14:27 -0700 [thread overview]
Message-ID: <20130822151427.38650aae09e909d52a57b393@linux-foundation.org> (raw)
In-Reply-To: <20130822215742.GA32040@quack.suse.cz>
On Thu, 22 Aug 2013 23:57:42 +0200 Jan Kara <jack@suse.cz> wrote:
> On Thu 22-08-13 12:49:13, Andrew Morton wrote:
> > Desperately seeking alternatives...
> >
> > I suppose there's some reason why we can't just make those drivers shut
> > up? If the messages are in the log buffer but aren't displayed,
> > they're still accessible after boot?
> >
> > Or how about passing those messages over to a kernel thread, to be
> > printed out at a lower rate? A linked list and schedule_work() would
> > suffice.
>
> Andrew, you seem really desperate ;-)
Years of hard experience have taught me: don't muck with printk. It
needs to be robust, simple and to have minimum dependency on both the
calling environment and on correctly functioning kernel components.
printk and NMI are the harshest environments we have to deal with.
> I don't really like modifying
> individual drivers, partitioning code, or SCSI core to be less verbose -
> IMHO that's fighting with windmills and it's not like any of those parts is
> excessively verbose. Every part prints its bits and it accumulates. I
> cannot really imagine this would work long term.
>
> Handing over printing to someone else is exactly what I'm doing
No you aren't - you're mucking with printk!
What I'm proposing is to put a front-end *before* printk. Thus leaving
printk unmucked with.
But it was just a suggestion. Maybe there are other ways. I'm
inviting you to suggest ways of fixing this obscure corner case
without mucking with everyone's printk.
next prev parent reply other threads:[~2013-08-22 22:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 8:08 Jan Kara
2013-08-21 8:08 ` [PATCH 1/4] printk: Remove separate printk_sched buffers and use printk buf instead Jan Kara
2013-08-21 8:08 ` [PATCH 2/4] irq_work: Provide a irq work that can be processed on any cpu Jan Kara
2013-08-21 18:49 ` Steven Rostedt
2013-09-05 15:56 ` Jan Kara
2013-08-21 8:08 ` [PATCH 3/4] printk: Defer printing to irq work when we printed too much Jan Kara
2013-08-21 19:06 ` Steven Rostedt
2013-08-21 8:08 ` [PATCH 4/4] printk: Use unbound irq work for printing and waking Jan Kara
2013-08-21 19:24 ` Steven Rostedt
2013-08-21 21:27 ` [PATCH 0/4 v6] Avoid softlockups in console_unlock() Andrew Morton
2013-08-21 22:59 ` Jan Kara
2013-08-22 19:49 ` Andrew Morton
2013-08-22 21:57 ` Jan Kara
2013-08-22 22:14 ` Andrew Morton [this message]
2013-08-23 19:50 ` Jiri Kosina
2013-08-23 19:48 ` Jiri Kosina
2013-08-23 19:58 ` Andrew Morton
2013-08-26 11:48 ` Jiri Kosina
2013-09-05 15:46 ` Jan Kara
2013-09-19 21:26 ` Andrew Morton
2013-09-20 21:55 ` Jan Kara
2013-11-07 21:48 Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130822151427.38650aae09e909d52a57b393@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®