From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755224Ab3HWOu3 (ORCPT ); Fri, 23 Aug 2013 10:50:29 -0400 Received: from mail-ee0-f48.google.com ([74.125.83.48]:59707 "EHLO mail-ee0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754547Ab3HWOu2 (ORCPT ); Fri, 23 Aug 2013 10:50:28 -0400 Date: Fri, 23 Aug 2013 15:50:18 +0100 From: Lee Jones To: Linus Walleij Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Arnd Bergmann Subject: Re: [PATCH 33/40] ARM: ux500: Don't register the STMPE/SKE when booting with ATAG support Message-ID: <20130823145018.GE19107@lee--X1> References: <1377260620-18829-1-git-send-email-lee.jones@linaro.org> <1377260620-18829-34-git-send-email-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 23 Aug 2013, Linus Walleij wrote: > On Fri, Aug 23, 2013 at 2:55 PM, Linus Walleij wrote: > > On Fri, Aug 23, 2013 at 2:23 PM, Lee Jones wrote: > > > >> It's time to remove all ATAG support from ux500 and rely solely on > >> Device Tree booting. This patch is part of that endeavour. > >> > >> Signed-off-by: Lee Jones > > (...) > >> -/* STMPE/SKE keypad use this key layout */ > >> -static const unsigned int mop500_keymap[] = { > >> - KEY(2, 5, KEY_END), > >> - KEY(4, 1, KEY_POWER), > >> - KEY(3, 5, KEY_VOLUMEDOWN), > >> - KEY(1, 3, KEY_3), > >> - KEY(5, 2, KEY_RIGHT), > >> - KEY(5, 0, KEY_9), > >> - > >> - KEY(0, 5, KEY_MENU), > >> - KEY(7, 6, KEY_ENTER), > >> - KEY(4, 5, KEY_0), > >> - KEY(6, 7, KEY_2), > >> - KEY(3, 4, KEY_UP), > >> - KEY(3, 3, KEY_DOWN), > >> - > >> - KEY(6, 4, KEY_SEND), > >> - KEY(6, 2, KEY_BACK), > >> - KEY(4, 2, KEY_VOLUMEUP), > >> - KEY(5, 5, KEY_1), > >> - KEY(4, 3, KEY_LEFT), > >> - KEY(3, 2, KEY_7), > >> -}; > > > > This STMPE1601 keypad @0x40 and UIB encoding for > > the U8500 UIB does not exist in any DTS file does it? This > > means that the support for this UIB is effectively terminated. > > You are wrong. Go read arch/arm/boot/dts/[ste-]stuib.dtsi. > > Anyway, what you wanted to say was for these to be marked > "disabled" by default and turned into "okay" using an I2C > probe operation. Why are you talking to yourself? Have you finally lost it? -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog