From: Eric Wong <normalperson@yhbt.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Al Viro <viro@ZenIV.linux.org.uk>,
edumazet@google.com, "Theodore Ts'o" <tytso@mit.edu>
Subject: Re: [PATCH] epoll: add a reschedule point in ep_free()
Date: Tue, 27 Aug 2013 23:33:00 +0000 [thread overview]
Message-ID: <20130827233300.GA14061@dcvr.yhbt.net> (raw)
In-Reply-To: <1376751997.21329.8.camel@edumazet-glaptop>
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> ep_free() might iterate on a huge set of epitems and hold
> cpu too long. Add two cond_resched() in order to yield cpu
> to other tasks. This is safe as we only hold mutexes in
> this function.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Al Viro <viro@ZenIV.linux.org.uk>
> Cc: Theodore Ts'o <tytso@mit.edu>
Seems reasonable. This isn't a remotely hot path and f_op->release
runs in a workqueue nowadays (right?).
Acked-by: Eric Wong <normalperson@yhbt.net>
prev parent reply other threads:[~2013-08-27 23:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-17 15:06 Eric Dumazet
2013-08-27 23:33 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130827233300.GA14061@dcvr.yhbt.net \
--to=normalperson@yhbt.net \
--cc=akpm@linux-foundation.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®