From: Sascha Hauer <s.hauer@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH] imx-drm: Fix probe failure
Date: Wed, 28 Aug 2013 22:34:19 +0200 [thread overview]
Message-ID: <20130828203418.GW30088@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5CuGAH+5+8cE7tjzZTXhLbFxMRt13mhimuBLJkRQz6+7Q@mail.gmail.com>
On Wed, Aug 28, 2013 at 05:10:16PM -0300, Fabio Estevam wrote:
> On Wed, Aug 28, 2013 at 3:54 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> > Do the open/close callbacks work?
>
> The 'open' callback maps to the generic 'drm_open', so we cannot use it.
We could replace this, but...
>
> Shouldn't we rely on the refcount done by the drm core instead of
> doing this manually in imx-drm?
...This could be a better solution.
you mean (struct drm_device)->open_count, right?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2013-08-28 20:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 2:32 Fabio Estevam
2013-08-28 3:11 ` Greg KH
2013-08-28 3:24 ` Fabio Estevam
2013-08-28 5:27 ` Sascha Hauer
2013-08-28 14:39 ` Fabio Estevam
2013-08-28 18:54 ` Sascha Hauer
2013-08-28 20:10 ` Fabio Estevam
2013-08-28 20:34 ` Sascha Hauer [this message]
2013-08-28 22:30 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828203418.GW30088@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome