From: Sascha Hauer <s.hauer@pengutronix.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Dave Airlie <airlied@redhat.com>,
daniel.vetter@ffwll.ch,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] imx-drm: Fix probe failure
Date: Fri, 30 Aug 2013 19:06:18 +0200 [thread overview]
Message-ID: <20130830170618.GE30088@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5ANriVriw5W6qPG7OxPAsbvVHfZfzoCJk-d3aiAtyQkFA@mail.gmail.com>
On Fri, Aug 30, 2013 at 01:08:14PM -0300, Fabio Estevam wrote:
> Hi Sascha,
>
> On Thu, Aug 29, 2013 at 3:37 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > It's not about the module refcount. It's only that a on a drm device
> > which is in use you better do not add/remove components.
> >
> > Again: The imx-drm driver does *not* do hotplugging. It will *not* add
> > or remove components when the device is opened. The code you remove
> > exactly makes (or made before Daniels patch) that sure.
>
> I am not sure what would be the correct fix for this.
Why not use (struct drm_device)->open_count as suggested earlier?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2013-08-30 17:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 13:59 Fabio Estevam
2013-08-29 15:21 ` Daniel Vetter
2013-08-29 18:31 ` Sascha Hauer
2013-08-29 18:14 ` Sascha Hauer
2013-08-29 18:30 ` Fabio Estevam
2013-08-29 18:37 ` Sascha Hauer
2013-08-30 16:08 ` Fabio Estevam
2013-08-30 17:06 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130830170618.GE30088@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=airlied@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome