From: Simon Horman <horms@verge.net.au>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux@arm.linux.org.uk, arnd@arndb.de, linux-sh@vger.kernel.org,
sboyd@codeaurora.org, rob.herring@calxeda.com, olof@lixom.net,
santosh.shilimkar@ti.com, grant.likely@linaro.org,
tglx@linutronix.de
Subject: Re: [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast
Date: Wed, 4 Sep 2013 17:37:29 +0900 [thread overview]
Message-ID: <20130904083727.GE17329@verge.net.au> (raw)
In-Reply-To: <20130904080151.24562.91334.sendpatchset@w520>
[ Droped johnstultz@linaro.org CC, the address seems to bounce
Added Daniel Lezcano CC, I believe he handles clocksource these days ]
On Wed, Sep 04, 2013 at 05:01:51PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Update the STI driver by setting cpu_possible_mask to make EMEV2
> SMP work as expected together with the ARM broadcast timer.
>
> This breakage was introduced by:
>
> f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event
>
> Without this fix SMP operation is broken on EMEV2 since no
> broadcast timer interrupts trigger on the secondary CPU cores.
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
Tested-by: Simon Horman <horms+renesas@verge.net.au>
I will let this sit for a few days to see if there is any further feedback.
> ---
>
> Thanks to feedback from Stephen Boyd this is is a reworked version of:
> [PATCH] clocksource: em_sti: Adjust clock event rating to fix SMP broadcast
>
> drivers/clocksource/em_sti.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- 0001/drivers/clocksource/em_sti.c
> +++ work/drivers/clocksource/em_sti.c 2013-09-04 16:51:42.000000000 +0900
> @@ -301,7 +301,7 @@ static void em_sti_register_clockevent(s
> ced->name = dev_name(&p->pdev->dev);
> ced->features = CLOCK_EVT_FEAT_ONESHOT;
> ced->rating = 200;
> - ced->cpumask = cpumask_of(0);
> + ced->cpumask = cpu_possible_mask;
> ced->set_next_event = em_sti_clock_event_next;
> ced->set_mode = em_sti_clock_event_mode;
>
>
next prev parent reply other threads:[~2013-09-04 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130904080151.24562.91334.sendpatchset@w520>
2013-09-04 8:31 ` Simon Horman
2013-09-04 8:37 ` Simon Horman [this message]
2013-09-04 8:44 ` Daniel Lezcano
2013-09-04 16:29 ` Stephen Boyd
2013-09-05 7:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904083727.GE17329@verge.net.au \
--to=horms@verge.net.au \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=santosh.shilimkar@ti.com \
--cc=sboyd@codeaurora.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®