From: Lee Jones <lee.jones@linaro.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, anton@enomsg.org
Subject: Re: [PATCH 3/4] pm2301-charger: Check return value of regulator_enable
Date: Wed, 4 Sep 2013 10:42:34 +0100 [thread overview]
Message-ID: <20130904094234.GE20150@lee--X1> (raw)
In-Reply-To: <1378120226-24805-3-git-send-email-sachin.kamat@linaro.org>
On Mon, 02 Sep 2013, Sachin Kamat wrote:
> Check the return value of regulator_enable to silence the following
> warning:
> drivers/power/pm2301_charger.c:725:20: warning:
> ignoring return value of ‘regulator_enable’, declared with
> attribute warn_unused_result [-Wunused-result]
Same thing here.
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/power/pm2301_charger.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/pm2301_charger.c b/drivers/power/pm2301_charger.c
> index ffa10ed..ab87d1a 100644
> --- a/drivers/power/pm2301_charger.c
> +++ b/drivers/power/pm2301_charger.c
> @@ -722,7 +722,12 @@ static int pm2xxx_charger_ac_en(struct ux500_charger *charger,
>
> dev_dbg(pm2->dev, "Enable AC: %dmV %dmA\n", vset, iset);
> if (!pm2->vddadc_en_ac) {
> - regulator_enable(pm2->regu);
> + ret = regulator_enable(pm2->regu);
> + if (ret) {
> + dev_err(pm2->dev,
> + "Failed to enable regulator\n");
> + goto error_occured;
> + }
> pm2->vddadc_en_ac = true;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-09-04 9:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-02 11:10 [PATCH 1/4] ab8500-charger: " Sachin Kamat
2013-09-02 11:10 ` [PATCH 2/4] ab8500-charger: Remove redundant break Sachin Kamat
2013-09-02 11:10 ` [PATCH 3/4] pm2301-charger: Check return value of regulator_enable Sachin Kamat
2013-09-04 9:42 ` Lee Jones [this message]
2013-09-02 11:10 ` [PATCH 4/4] pm2301-charger: Staticize pm2xxx_charger_die_therm_mngt Sachin Kamat
2013-09-04 9:43 ` Lee Jones
2013-09-04 9:41 ` [PATCH 1/4] ab8500-charger: Check return value of regulator_enable Lee Jones
2013-09-04 9:58 ` Sachin Kamat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904094234.GE20150@lee--X1 \
--to=lee.jones@linaro.org \
--cc=anton@enomsg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome