From: Mark Brown <broonie@kernel.org>
To: Nishanth Menon <nm@ti.com>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
gg@slimlogic.co.uk, Sascha Hauer <s.hauer@pengutronix.de>,
marek.vasut@gmail.com, Nancy.Chen@freescale.com
Subject: Re: [PATCH 7/7] regulator: ti-abb: Use devm_regulator_register
Date: Wed, 4 Sep 2013 19:03:19 +0100 [thread overview]
Message-ID: <20130904180319.GW3084@sirena.org.uk> (raw)
In-Reply-To: <5227674A.9020005@ti.com>
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
On Wed, Sep 04, 2013 at 12:00:58PM -0500, Nishanth Menon wrote:
> > As I mentioned earlier generally when you do these kind of
> > conversions, most of the trivial
> > clean-ups are also done along with it. Probably you would have
> > appreciated a mention about
> > this in the commit log too.
> yes, adding to commit log might have helped me. thanks for the cleanup
> as well.
Indeed, that is good practice - either submit the changes separately or
mention all of them in the changelog.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-04 18:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 6:30 [PATCH 1/7] regulator: anatop-regulator: " Sachin Kamat
2013-09-04 6:30 ` [PATCH 2/7] regulator: isl6271a-regulator: " Sachin Kamat
2013-09-04 14:26 ` Marek Vasut
2013-09-04 6:30 ` [PATCH 3/7] regulator: mc13783: " Sachin Kamat
2013-09-04 14:27 ` Marek Vasut
2013-09-04 6:31 ` [PATCH 4/7] regulator: mc13892: " Sachin Kamat
2013-09-04 14:29 ` Marek Vasut
2013-09-04 6:31 ` [PATCH 5/7] regulator: palmas: " Sachin Kamat
2013-09-04 14:32 ` Marek Vasut
2013-09-04 15:14 ` Sachin Kamat
2013-09-04 6:31 ` [PATCH 6/7] regulator: rc5t583: " Sachin Kamat
2013-09-04 14:33 ` Marek Vasut
2013-09-04 6:31 ` [PATCH 7/7] regulator: ti-abb: " Sachin Kamat
2013-09-04 13:27 ` Nishanth Menon
2013-09-04 15:12 ` Mark Brown
2013-09-04 15:15 ` Nishanth Menon
2013-09-04 16:26 ` Sachin Kamat
2013-09-04 16:33 ` Nishanth Menon
2013-09-04 16:48 ` Sachin Kamat
2013-09-04 17:00 ` Nishanth Menon
2013-09-04 18:03 ` Mark Brown [this message]
2013-09-04 9:49 ` [PATCH 1/7] regulator: anatop-regulator: " Mark Brown
2013-09-04 14:25 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130904180319.GW3084@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Nancy.Chen@freescale.com \
--cc=gg@slimlogic.co.uk \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=nm@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®