mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com>
Cc: Ashish Chavan <ashish.chavan@kpitcummins.com>, lrg <lrg@ti.com>,
	alsa-devel <alsa-devel@alsa-project.org>,
	David Dajun Chen <david.chen@diasemi.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"kiran.padwal" <kiran.padwal@kpitcummins.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: codecs: da9055: Update driver name to fix breakage due to pmic driver with same name
Date: Wed, 4 Sep 2013 19:34:05 +0100	[thread overview]
Message-ID: <20130904183405.GX3084@sirena.org.uk> (raw)
In-Reply-To: <2E89032DDAA8B9408CB92943514A033751E6157D@SW-EX-MBX01.diasemi.com>

[-- Attachment #1: Type: text/plain, Size: 964 bytes --]

On Wed, Sep 04, 2013 at 04:13:25PM +0000, Opensource [Adam Thomson] wrote:

> Personally I don't see the issue in having two I2C clients defined for the one
> chip, in the machine bindings. Logically it's absolutely correct for the chip,
> and as long as the I2C IDs for the devices make sense (which wasn't the case for
> DA9055, and is something I want to rectify), then it should be obvious
> to anyone who comes across that code. Actually having them as two separate
> entries in machine code helps to highlight that they are individual I2C devices
> in one package rather than somehow linked internally and requiring ordered
> initialisation. That seems right to me, and would tally with the associated
> datasheet for the device.

The goal is that users shouldn't even need to have to think about how
the chip is constructed, they should just be able to use it with minimal
thought or effort.  Anything that can be encapsulated within the drivers
should be.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2013-09-04 18:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1373024862.3233.63.camel@matrix>
2013-07-05 11:44 ` Mark Brown
     [not found]   ` <1373031306.3233.131.camel@matrix>
2013-07-05 13:37     ` Mark Brown
     [not found]       ` <1373270091.11222.12.camel@matrix>
2013-07-08 11:26         ` Mark Brown
     [not found]           ` <1373542576.9286.101.camel@matrix>
2013-07-17 10:36             ` Mark Brown
     [not found]               ` <1374482594.13726.11.camel@matrix>
2013-07-22 10:02                 ` Mark Brown
     [not found]                   ` <1375110386.21326.6.camel@matrix>
2013-07-29 16:01                     ` Mark Brown
     [not found]                       ` <1375689331.28910.5.camel@matrix>
2013-08-05 14:42                         ` Mark Brown
     [not found]                           ` <1375717898.29528.23.camel@matrix>
2013-08-05 16:23                             ` Mark Brown
     [not found]                               ` <1377778108.15438.6.camel@matrix>
     [not found]                                 ` <2E89032DDAA8B9408CB92943514A033751E611AF@SW-EX-MBX01.diasemi.com>
2013-09-02 10:38                                   ` Mark Brown
     [not found]                                     ` <2E89032DDAA8B9408CB92943514A033751E612F5@SW-EX-MBX01.diasemi.com>
2013-09-02 17:41                                       ` Mark Brown
     [not found]                                         ` <2E89032DDAA8B9408CB92943514A033751E6157D@SW-EX-MBX01.diasemi.com>
2013-09-04 18:34                                           ` Mark Brown [this message]
     [not found]                                             ` <2E89032DDAA8B9408CB92943514A033751E61991@SW-EX-MBX01.diasemi.com>
2013-09-09 11:26                                               ` Mark Brown
     [not found]                                                 ` <2E89032DDAA8B9408CB92943514A033751E630F5@SW-EX-MBX01.diasemi.com>
2013-09-10 17:07                                                   ` Mark Brown
     [not found]                                                     ` <2E89032DDAA8B9408CB92943514A033751E634EF@SW-EX-MBX01.diasemi.com>
2013-09-12 21:58                                                       ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130904183405.GX3084@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=Adam.Thomson.Opensource@diasemi.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=ashish.chavan@kpitcummins.com \
    --cc=david.chen@diasemi.com \
    --cc=kiran.padwal@kpitcummins.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®