From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: adi@drcomp.erfurt.thur.de
Subject: Re: ALSA: hdspm - AES32: Enable TCO/Sync-In in snd_hdspm_put_sync_ref()
Date: Thu, 5 Sep 2013 10:50:13 -0400 [thread overview]
Message-ID: <20130905145013.GC15894@redhat.com> (raw)
In-Reply-To: <20130905013837.9F84A660DA9@gitolite.kernel.org>
On Thu, Sep 05, 2013 at 01:38:37AM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=2d60fc7f7d3d79e5646646bb34811961f19d111a
> Commit: 2d60fc7f7d3d79e5646646bb34811961f19d111a
> Parent: dbae4a0c8d8794df1a6bd7e644ed94b915f46f7e
> Author: Adrian Knoth <adi@drcomp.erfurt.thur.de>
> AuthorDate: Fri Jul 5 11:28:15 2013 +0200
> Committer: Takashi Iwai <tiwai@suse.de>
> CommitDate: Fri Jul 5 14:52:42 2013 +0200
>
> ALSA: hdspm - AES32: Enable TCO/Sync-In in snd_hdspm_put_sync_ref()
> static int hdspm_autosync_ref(struct hdspm *hdspm)
> {
...
> + unsigned int syncref = (status >> HDSPM_AES32_syncref_bit) & 0xF;
> + if ((syncref >= HDSPM_AES32_AUTOSYNC_FROM_WORD) &&
> + (syncref <= HDSPM_AES32_AUTOSYNC_FROM_SYNC_IN)) {
> return syncref;
> + }
Because syncref is unsigned, the first part of that if always evaluates true.
(it will always be >0)
Dave
next parent reply other threads:[~2013-09-05 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130905013837.9F84A660DA9@gitolite.kernel.org>
2013-09-05 14:50 ` Dave Jones [this message]
2013-09-05 15:01 ` Takashi Iwai
2013-09-05 15:21 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130905145013.GC15894@redhat.com \
--to=davej@redhat.com \
--cc=adi@drcomp.erfurt.thur.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®