From: Mark Brown <broonie@kernel.org>
To: Tomasz Figa <tomasz.figa@gmail.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
lee.jones@linaro.org, Rob Herring <rob.herring@calxeda.com>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ian.campbell@citrix.com>,
Rob Landley <rob@landley.net>,
Samuel Ortiz <sameo@linux.intel.com>,
Grant Likely <grant.likely@linaro.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Jonghwa Lee <jonghwa3.lee@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] max77693: added device tree support
Date: Fri, 6 Sep 2013 11:50:03 +0100 [thread overview]
Message-ID: <20130906105003.GB29403@sirena.org.uk> (raw)
In-Reply-To: <3144986.QWu11iEeBj@flatron>
[-- Attachment #1: Type: text/plain, Size: 796 bytes --]
On Fri, Aug 23, 2013 at 10:08:39PM +0200, Tomasz Figa wrote:
> On Wednesday 21 of August 2013 18:53:34 Andrzej Hajda wrote:
> > +#ifdef CONFIG_OF
> > +static struct of_device_id max77693_dt_match[] = {
> > + {.compatible = "maxim,max77693"},
> > + {},
> > +};
> > +#endif
> As far as I'm aware of, you don't need explicit OF match table for I2C
> devices, because the I2C OF core can use the array of struct i2c_device_id
> pointed by .id_table field of struct i2c_driver.
> I'm not sure if a separate OF table isn't preferred, though, so your patch
> might be fine.
It's still good practice to explicitly define a binding since that
gives a vendor prefix and there are overlaps out there in chip vendor
namings - for example both Wolfson and Wondermedia use "WMxxxx".
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-06 10:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 16:53 [PATCH v3 0/2] " Andrzej Hajda
2013-08-21 16:53 ` [PATCH v3 1/2] max77693: remove device wakeup from driver Andrzej Hajda
2013-09-26 12:00 ` Andrzej Hajda
2013-09-27 7:29 ` Lee Jones
2013-08-21 16:53 ` [PATCH v3 2/2] max77693: added device tree support Andrzej Hajda
2013-08-23 14:14 ` Mark Rutland
2013-08-23 20:36 ` Tomasz Figa
2013-08-23 20:08 ` Tomasz Figa
2013-09-06 10:50 ` Mark Brown [this message]
2013-09-26 12:05 ` Andrzej Hajda
2013-09-27 7:17 ` Lee Jones
2013-09-27 7:27 ` [PATCH v4 " Andrzej Hajda
2013-09-27 8:11 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130906105003.GB29403@sirena.org.uk \
--to=broonie@kernel.org \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ian.campbell@citrix.com \
--cc=jonghwa3.lee@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=s.nawrocki@samsung.com \
--cc=sameo@linux.intel.com \
--cc=swarren@wwwdotorg.org \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®