From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752871Ab3IFM6l (ORCPT ); Fri, 6 Sep 2013 08:58:41 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:51729 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751325Ab3IFM6k (ORCPT ); Fri, 6 Sep 2013 08:58:40 -0400 Date: Fri, 6 Sep 2013 05:58:39 -0700 From: Christoph Hellwig To: Geert Uytterhoeven Cc: "David S. Miller" , sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sparc64: Export flush_ptrace_access() (needed by lustre) Message-ID: <20130906125839.GB6396@infradead.org> References: <1378372110-19094-1-git-send-email-geert@linux-m68k.org> <20130906125613.GA6396@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130906125613.GA6396@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 06, 2013 at 05:56:13AM -0700, Christoph Hellwig wrote: > On Thu, Sep 05, 2013 at 11:08:29AM +0200, Geert Uytterhoeven wrote: > > ERROR: "flush_ptrace_access" [drivers/staging/lustre/lustre/libcfs/libcfs.ko] > > undefined! > > This seems to be more copy_to_user_page fallout, so instead of all these > arch patches we should figure out why lustre absolutely wants to use > this API that so far has been for core MM code only. Looking at the code is seems to be for a reimplementation of __access_remote_vm. So at very least it should use that, but I still requiestion why it's doing that at all. Geert, please don't just export stuff for staging/ use only. Code wouldn't be in staging if it weren't a steaming pile of junk, so adjusting anyting in the real tree for it needs proper discussion first.