From: Lee Jones <lee.jones@linaro.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, ldewangan@nvidia.com,
Stephen Warren <swarren@nvidia.com>
Subject: Re: [PATCH] mfd: tps6586x: implement irq_set_wake
Date: Mon, 9 Sep 2013 10:07:08 +0100 [thread overview]
Message-ID: <20130909090708.GE22938@lee--X1> (raw)
In-Reply-To: <1378509433-26404-1-git-send-email-swarren@wwwdotorg.org>
On Fri, 06 Sep 2013, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> rtc-tps6586x calls enable/disable_irq_wake() during suspend/resume. Since
> the main tps6586x irq_chip doesn't implement .irq_set_wake, this causes
> the RTC's enable_irq_wake() to fail, and the disable_irq_wake() to spew a
> WARN about unbalanced wake disable. Solve this by implementing
> .irq_set_wake.
>
> Also, I assume that enable_irq_wake() shouldn't be called unconditionally
> in tps6586x_irq_init(), since this is now triggered by IRQ children
> setting up their cascaded IRQs for wake. So, remove that.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> I'm tempted to Cc stable here, since this bug is certainly present in
> older kernel releases. However, the only user-visible aspect is the WARN
> on resume, so I'm not sure if it's worth it?
Can't do any harm?
> ---
> drivers/mfd/tps6586x.c | 18 +++++++++++++++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
Patch applied.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2013-09-09 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 23:17 Stephen Warren
2013-09-09 9:07 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130909090708.GE22938@lee--X1 \
--to=lee.jones@linaro.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®