From: Peter Zijlstra <peterz@infradead.org>
To: John Stultz <john.stultz@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] [RFC] seqcount: Add lockdep functionality to seqcount/seqlock structures
Date: Tue, 10 Sep 2013 11:19:45 +0200 [thread overview]
Message-ID: <20130910091945.GR26785@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20130910081156.GK26785@twins.programming.kicks-ass.net>
On Tue, Sep 10, 2013 at 10:11:56AM +0200, Peter Zijlstra wrote:
> On Mon, Sep 09, 2013 at 09:42:46PM -0700, John Stultz wrote:
> > +++ b/include/linux/lockdep.h
> > @@ -510,6 +510,21 @@ static inline void print_irqtrace_events(struct task_struct *curr)
> >
> > #ifdef CONFIG_DEBUG_LOCK_ALLOC
> > # ifdef CONFIG_PROVE_LOCKING
> > +# define seqcount_acquire(l, s, t, i) lock_acquire(l, s, t, 0, 2, NULL, i)
> > +# define seqcount_acquire_read(l, s, t, i) lock_acquire(l, s, t, 2, 2, NULL, i)
> > +# else
> > +# define seqcount_acquire(l, s, t, i) lock_acquire(l, s, t, 0, 1, NULL, i)
> > +# define seqcount_acquire_read(l, s, t, i) lock_acquire(l, s, t, 2, 1, NULL, i)
> > +# endif
> > +# define seqcount_release(l, n, i) lock_release(l, n, i)
> > +#else
> > +# define seqcount_acquire(l, s, t, i) do { } while (0)
> > +# define seqcount_acquire_read(l, s, t, i) do { } while (0)
> > +# define seqcount_release(l, n, i) do { } while (0)
> > +#endif
>
> Please look at a recent lockdep.h, this pattern changed a little.
And when you're there, can you please remove the superfluous whitespace
before rwsem_release and lock_map_release ?
next prev parent reply other threads:[~2013-09-10 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 4:42 John Stultz
2013-09-10 8:11 ` Peter Zijlstra
2013-09-10 9:19 ` Peter Zijlstra [this message]
2013-09-10 8:43 ` Peter Zijlstra
2013-09-10 16:28 ` John Stultz
2013-09-10 8:55 ` Peter Zijlstra
2013-09-10 16:32 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130910091945.GR26785@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®