From: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
To: Michael Opdenacker <michael.opdenacker@free-electrons.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ehea: remove deprecated IRQF_DISABLED
Date: Thu, 12 Sep 2013 09:05:00 -0300 [thread overview]
Message-ID: <20130912120500.GB28361@oc0268524204.ibm.com> (raw)
In-Reply-To: <1378957571-3574-1-git-send-email-michael.opdenacker@free-electrons.com>
On Thu, Sep 12, 2013 at 05:46:11AM +0200, Michael Opdenacker wrote:
> This patch proposes to remove the IRQF_DISABLED flag from
> drivers/net/ethernet/ibm/ehea/ehea_main.c
>
> It's a NOOP since 2.6.35 and it will be removed one day.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> ---
> drivers/net/ethernet/ibm/ehea/ehea_main.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> index 35853b4..04e0ef1 100644
> --- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
> +++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
> @@ -1285,7 +1285,7 @@ static int ehea_reg_interrupts(struct net_device *dev)
>
> ret = ibmebus_request_irq(port->qp_eq->attr.ist1,
> ehea_qp_aff_irq_handler,
> - IRQF_DISABLED, port->int_aff_name, port);
> + 0, port->int_aff_name, port);
> if (ret) {
> netdev_err(dev, "failed registering irq for qp_aff_irq_handler:ist=%X\n",
> port->qp_eq->attr.ist1);
> @@ -1303,8 +1303,7 @@ static int ehea_reg_interrupts(struct net_device *dev)
> "%s-queue%d", dev->name, i);
> ret = ibmebus_request_irq(pr->eq->attr.ist1,
> ehea_recv_irq_handler,
> - IRQF_DISABLED, pr->int_send_name,
> - pr);
> + 0, pr->int_send_name, pr);
> if (ret) {
> netdev_err(dev, "failed registering irq for ehea_queue port_res_nr:%d, ist=%X\n",
> i, pr->eq->attr.ist1);
> @@ -3320,7 +3319,7 @@ static int ehea_probe_adapter(struct platform_device *dev)
> }
>
> ret = ibmebus_request_irq(adapter->neq->attr.ist1,
> - ehea_interrupt_neq, IRQF_DISABLED,
> + ehea_interrupt_neq, 0,
> "ehea_neq", adapter);
> if (ret) {
> dev_err(&dev->dev, "requesting NEQ IRQ failed\n");
> --
> 1.8.1.2
>
Acked-by: Thadeu Lima de Souza Cascardo <cascardo@linux.vnet.ibm.com>
next prev parent reply other threads:[~2013-09-12 12:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 3:46 Michael Opdenacker
2013-09-12 12:05 ` Thadeu Lima de Souza Cascardo [this message]
2013-09-13 3:27 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912120500.GB28361@oc0268524204.ibm.com \
--to=cascardo@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.opdenacker@free-electrons.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®