From: Jiri Olsa <jolsa@redhat.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>,
Pekka Enberg <penberg@kernel.org>,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf tools: Separate out GTK codes to libperf-gtk.so
Date: Thu, 12 Sep 2013 14:31:56 +0200 [thread overview]
Message-ID: <20130912123156.GA15187@krava.brq.redhat.com> (raw)
In-Reply-To: <1378967659-30104-1-git-send-email-namhyung@kernel.org>
On Thu, Sep 12, 2013 at 03:34:19PM +0900, Namhyung Kim wrote:
> Separate out GTK codes to a shared object called libperf-gtk.so. This
SNIP
> pthread_mutex_t ui__lock = PTHREAD_MUTEX_INITIALIZER;
> +void *perf_gtk_handle;
> +
> +#ifdef GTK2_SUPPORT
> +static int setup_gtk_browser(void)
> +{
> + int (*perf_ui_init)(void);
> +
> + if (perf_gtk_handle)
> + return 0;
> +
> + perf_gtk_handle = dlopen("libperf-gtk.so", RTLD_LAZY);
> + if (perf_gtk_handle == NULL)
> + return -1;
shouldn't we try for known installed path here?
$ perf report --gtk
GTK browser requested but could not find libperf-gtk.so
otherwise I need to do some ld.conf setup or run it like this:
LD_LIBRARY_PATH=/home/jolsa/lib64/ ./perf report --gtk
LD_LIBRARY_PATH=./ ./perf report --gtk
jirka
next prev parent reply other threads:[~2013-09-12 12:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 6:34 Namhyung Kim
2013-09-12 12:31 ` Jiri Olsa [this message]
2013-09-13 6:27 ` [PATCH v6] " Namhyung Kim
2013-09-19 19:50 ` Arnaldo Carvalho de Melo
2013-10-15 5:25 ` [tip:perf/core] " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912123156.GA15187@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®