From: Sam Ravnborg <sam@ravnborg.org>
To: Mark Salter <msalter@redhat.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
rth@twiddle.net, vgupta@synopsys.com, linux@arm.linux.org.uk,
tony.luck@intel.com, geert@linux-m68k.org, monstr@monstr.eu,
ralf@linux-mips.org, jejb@parisc-linux.org,
benh@kernel.crashing.org, lethal@linux-sh.org,
davem@davemloft.net, cmetcalf@tilera.com, gxt@mprc.pku.edu.cn,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com
Subject: Re: [PATCH] Kconfig cleanup (PARPORT_PC dependencies)
Date: Thu, 12 Sep 2013 22:32:04 +0200 [thread overview]
Message-ID: <20130912203204.GA26170@merkur.ravnborg.org> (raw)
In-Reply-To: <1379012038-31764-1-git-send-email-msalter@redhat.com>
On Thu, Sep 12, 2013 at 02:53:58PM -0400, Mark Salter wrote:
> Remove messy dependencies from PARPORT_PC by having it depend on one
> Kconfig symbol (ARCH_MAY_HAVE_PC_PARPORT) and having architectures
> which need it declare ARCH_MAY_HAVE_PC_PARPORT in arch/*/Kconfig.
> New architectures are unlikely to need PARPORT_PC, so this avoids
> having an ever growing list of architectures to exclude. Those
> architectures which do declare ARCH_MAY_HAVE_PC_PARPORT in this
> patch are the ones which have an asm/parport.h.
It is much nicer if you provide a config symbol only once.
And then let the architectures who want it select this symbol.
This is the pattern we use for similar things in many places today,
so it is best to follow that pattern.
Sam
next prev parent reply other threads:[~2013-09-12 20:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 18:53 Mark Salter
2013-09-12 19:04 ` Chris Metcalf
2013-09-12 19:19 ` Mark Salter
2013-09-12 19:11 ` Geert Uytterhoeven
2013-09-12 19:13 ` Richard Henderson
2013-09-12 20:07 ` H. Peter Anvin
2013-09-12 20:53 ` Ingo Molnar
2013-09-12 20:55 ` H. Peter Anvin
2013-09-12 20:32 ` Sam Ravnborg [this message]
2013-09-12 20:49 ` Russell King - ARM Linux
2013-09-12 21:21 ` Mark Salter
2013-09-13 16:40 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130912203204.GA26170@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=benh@kernel.crashing.org \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=hpa@zytor.com \
--cc=jejb@parisc-linux.org \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=msalter@redhat.com \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®