Re: [PATCH 2/4] regulator: add STw481x VMMC driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]

On Fri, Sep 13, 2013 at 09:00:08PM +0200, Linus Walleij wrote:
> On Sun, Sep 1, 2013 at 10:13 PM, Mark Brown <broonie@kernel.org> wrote:

> > I can put it on a branch so it can be pulled into arm-soc - it makes
> > life easier for framework refactorings to have the driver in the
> > regulator tree as well.  Would that be OK?

> Sure but then you need patch 1/4 in there as well. I don't know if that

It shouldn't do, the Kconfig dependencies should stop it actually
getting built until the MFD is merged into the same tree I'd expect?
But if it is required then I'm fine with it going via arm-soc only, it's
just easier to avoid mistakes if there's no new drivers in other trees.

> comment pertained to the situation prior to the v3.12 merge window
> though, can I take this in now maybe or is there still a stir in the
> regulator tree?

There's still stuff going on - devm_regulator_register() is the main one
I'm thinking of immediately.

> They are mutally exclusive. You cannot have both at the same
> time. The datasheet says:
> 
> 0 Internal LDO VMMC is used
> 1 External VMMC is used
> 
> If it is set to 1, the internal VMMC is disconnected. So it's
> like some internal mux. All designs I've seen use the internal
> regulator though.
> 
> I move this to probe() and used regulator_enable_regmap()
> instead.

Great, that seems more idiomatic.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]