mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Akhil Bhansali <AkhilAshok.Bhansali@hgst.com>
Cc: kbuild test robot <fengguang.wu@intel.com>,
	OS Engineering <osengineering@stec-inc.com>,
	Ramprasad Chinthekindi <Ramprasad.Chinthekindi@hgst.com>,
	"jmoyer@redhat.com" <jmoyer@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Amit Phansalkar <Amit.Phansalkar@hgst.com>
Subject: Re: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error: implicit declaration of function 'readq'
Date: Wed, 18 Sep 2013 08:36:16 -0600	[thread overview]
Message-ID: <20130918143616.GD28478@kernel.dk> (raw)
In-Reply-To: <87B0A48E21A1974AB4780BA3191524C20E6446@MYMBX4.stec-inc.ad>

On Wed, Sep 18 2013, Akhil Bhansali wrote:
> Hi Jens,
> 
> Please accept this patch that takes care of warnings related to i386 compilation.
> 1. Implicit function declaration of readq and writeq.
> 2. Format related warnings for VPRINTK.

You should get rid of the VPRINTK() as well, we do have debug facilities
in place you can use for printing.

And as mentioned a week or so ago, readq() isn't even used.

-- 
Jens Axboe


  reply	other threads:[~2013-09-18 14:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5230cf49.xeAraX9UUfBD+Brs%fengguang.wu@intel.com>
2013-09-13 12:59 ` Akhil Bhansali
2013-09-13 15:25   ` Jens Axboe
2013-09-18 10:05     ` Akhil Bhansali
2013-09-18 14:36       ` Jens Axboe [this message]
2013-09-19 12:09         ` Akhil Bhansali
2013-09-23 11:59           ` Akhil Bhansali
2013-09-23 14:20             ` Jens Axboe
2013-09-27 11:26               ` Akhil Bhansali
2013-09-27 18:12                 ` Jens Axboe
2013-09-28  2:47                   ` Jens Axboe
2013-09-18 19:24       ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130918143616.GD28478@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=AkhilAshok.Bhansali@hgst.com \
    --cc=Amit.Phansalkar@hgst.com \
    --cc=Ramprasad.Chinthekindi@hgst.com \
    --cc=fengguang.wu@intel.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osengineering@stec-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome