From: "George Spelvin" <linux@horizon.com>
To: dan.carpenter@oracle.com, penguin-kernel@I-love.SAKURA.ne.jp
Cc: akpm@linux-foundation.org, JBeulich@suse.com, joe@perches.com,
keescook@chromium.org, kosaki.motohiro@gmail.com,
linux-kernel@vger.kernel.org, linux@horizon.com,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH 0/2] vsprintf: ignore %n again
Date: 18 Sep 2013 11:22:09 -0400 [thread overview]
Message-ID: <20130918152209.16302.qmail@science.horizon.com> (raw)
In-Reply-To: <20130918141104.GT19256@mwanda>
> +#define printk(fmt, ...) do { \
> + compiletime_assert(__builtin_constant_p(fmt), \
> + "Non-constant format string"); \
> + printk(fmt, ##__VA_ARGS__); \
> +} while (0)
May I recommend __builtin_constant_p(*fmt). Since:
char buf[OVERFLOW_VULNERABILITY];
strcpy(buf, malicious_format);
printk(buf, args)
has __builtin_constant_p(buf), but it's not a constant format string.
next prev parent reply other threads:[~2013-09-18 15:23 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 7:43 Kees Cook
2013-09-16 7:43 ` [PATCH 1/2] remove all uses of printf's %n Kees Cook
2013-09-16 8:09 ` Geert Uytterhoeven
2013-09-16 15:00 ` Kees Cook
2013-09-17 13:06 ` Tetsuo Handa
2013-09-17 14:34 ` Kees Cook
2013-09-17 20:57 ` George Spelvin
2013-09-19 8:56 ` Tetsuo Handa
2013-09-19 14:28 ` Kees Cook
2013-09-20 4:09 ` Tetsuo Handa
2013-09-20 4:23 ` Joe Perches
2013-09-20 4:53 ` Kees Cook
2013-09-20 8:08 ` Jiri Slaby
2013-09-20 19:24 ` Kees Cook
2013-09-20 19:33 ` Joe Perches
2013-09-21 0:28 ` Tetsuo Handa
2013-09-22 8:09 ` George Spelvin
2013-09-22 8:16 ` Geert Uytterhoeven
2013-09-23 21:24 ` Kees Cook
2013-09-30 8:16 ` Tetsuo Handa
2013-09-16 11:41 ` Tetsuo Handa
2013-09-16 14:59 ` Kees Cook
2013-09-16 15:09 ` Joe Perches
2013-09-16 15:25 ` Kees Cook
2013-09-16 15:44 ` Joe Perches
2013-09-16 17:21 ` George Spelvin
2013-09-16 18:03 ` Joe Perches
2013-09-16 16:07 ` George Spelvin
2013-09-16 16:13 ` Joe Perches
2013-09-16 16:39 ` George Spelvin
2013-09-16 17:53 ` Joe Perches
2013-09-16 19:15 ` George Spelvin
2013-09-16 19:25 ` Joe Perches
2013-09-16 7:43 ` [PATCH 2/2] vsprintf: ignore %n again Kees Cook
2013-09-16 15:55 ` [PATCH 0/2] " Al Viro
2013-09-16 16:15 ` Lars-Peter Clausen
2013-09-16 16:30 ` George Spelvin
2013-09-16 18:20 ` Kees Cook
2013-09-18 13:14 ` Tetsuo Handa
2013-09-18 14:11 ` Dan Carpenter
2013-09-18 14:28 ` Dan Carpenter
2013-09-18 15:22 ` George Spelvin [this message]
2013-09-18 14:32 ` Kees Cook
2013-09-19 2:11 ` Tetsuo Handa
2013-09-19 7:08 ` Tetsuo Handa
2013-09-18 14:47 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918152209.16302.qmail@science.horizon.com \
--to=linux@horizon.com \
--cc=JBeulich@suse.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kosaki.motohiro@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®