From: Francois Romieu <romieu@fr.zoreil.com>
To: Igor Gnatenko <i.gnatenko.brain@gmail.com>
Cc: Mirko Lindner <mlindner@marvell.com>,
linux-kernel@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org,
Joseph Salisbury <joseph.salisbury@canonical.com>,
member graysky <graysky@archlinux.us>
Subject: Re: [REGRESSION][BISECTED] skge: add dma_mapping check
Date: Thu, 19 Sep 2013 00:08:19 +0200 [thread overview]
Message-ID: <20130918220819.GA11989@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1379494844.2294.12.camel@ThinkPad-X230.localdomain>
Igor Gnatenko <i.gnatenko.brain@gmail.com> :
> Since 136d8f377e1575463b47840bc5f1b22d94bf8f63 commit we have kernel
> panic on:
> 01:05.0 Ethernet controller [0200]: Marvell Technology Group Ltd.
>
> Screen: https://www.dropbox.com/s/mu3t3wxpxbn4ou5/IMAG0507.jpg
>
> RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1008323
Does the ugly stuff below against mainline make a difference ?
Note to testers: use a size argument above 500 for 'ping' to
exercize the relevant code path.
diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c
index ef94a59..aa85a3f 100644
--- a/drivers/net/ethernet/marvell/skge.c
+++ b/drivers/net/ethernet/marvell/skge.c
@@ -3086,6 +3086,7 @@ static struct sk_buff *skge_rx_get(struct net_device *dev,
PCI_DMA_FROMDEVICE);
skge_rx_reuse(e, skge->rx_buf_size);
} else {
+ struct skge_element ee = *e;
struct sk_buff *nskb;
nskb = netdev_alloc_skb_ip_align(dev, skge->rx_buf_size);
@@ -3098,10 +3099,10 @@ static struct sk_buff *skge_rx_get(struct net_device *dev,
}
pci_unmap_single(skge->hw->pdev,
- dma_unmap_addr(e, mapaddr),
- dma_unmap_len(e, maplen),
+ dma_unmap_addr(&ee, mapaddr),
+ dma_unmap_len(&ee, maplen),
PCI_DMA_FROMDEVICE);
- skb = e->skb;
+ skb = ee.skb;
prefetch(skb->data);
}
next prev parent reply other threads:[~2013-09-18 22:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 9:00 Igor Gnatenko
2013-09-18 15:22 ` Ben Hutchings
2013-09-18 22:08 ` Francois Romieu [this message]
2013-09-19 8:18 ` Igor Gnatenko
2013-09-19 9:03 ` Igor Gnatenko
2013-09-24 15:16 ` Joseph Salisbury
2013-09-24 17:50 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918220819.GA11989@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=graysky@archlinux.us \
--cc=i.gnatenko.brain@gmail.com \
--cc=joseph.salisbury@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®