From: Mark Brown <broonie@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Marc Reilly <marc@cpdesign.com.au>,
u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org
Subject: Re: [PATCH 2/3] mfd: mc13xxx: Move SPI erratum workaround into SPI I/O function
Date: Thu, 19 Sep 2013 13:09:51 +0100 [thread overview]
Message-ID: <20130919120951.GO21013@sirena.org.uk> (raw)
In-Reply-To: <20130919114910.GE22389@lee--X1>
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
On Thu, Sep 19, 2013 at 12:49:10PM +0100, Lee Jones wrote:
> > > Either way, it needs changing.
> > Let's see if someone actually tests the code first though.
> I've taken the liberty of bulding it, but I don't have the h/w to
> actually run the code.
> I get:
> drivers/mfd/mc13xxx-spi.c: In function ‘mc13xxx_spi_write’:
> drivers/mfd/mc13xxx-spi.c:97:14: warning: initialisation discards ‘const’ qualifier from pointer target type [enabled by default]
Sure, but like I say let's see if the code actually works first.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-19 12:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 18:06 [PATCH 1/3] mfd: mc13xxx: Don't require lock for simple register I/O Mark Brown
2013-09-18 18:06 ` [PATCH 2/3] mfd: mc13xxx: Move SPI erratum workaround into SPI I/O function Mark Brown
2013-09-19 9:13 ` Lee Jones
2013-09-19 9:56 ` Mark Brown
2013-09-19 10:04 ` Lee Jones
2013-09-19 11:41 ` Mark Brown
2013-09-19 11:49 ` Lee Jones
2013-09-19 12:09 ` Mark Brown [this message]
2013-09-18 18:06 ` [PATCH 3/3] ASoC: mc13783: Use regmap directly from ASoC Mark Brown
2013-09-23 18:14 [PATCH 1/3] mfd: mc13xxx: Don't require lock for simple register I/O Mark Brown
2013-09-23 18:14 ` [PATCH 2/3] mfd: mc13xxx: Move SPI erratum workaround into SPI I/O function Mark Brown
2013-09-25 11:19 ` Lee Jones
2013-09-25 11:31 ` Mark Brown
2013-09-25 11:46 ` Lee Jones
2013-09-25 11:55 ` Lee Jones
2013-09-25 12:35 ` Mark Brown
2013-09-25 12:51 ` Lee Jones
2013-09-25 12:55 ` Mark Brown
2013-09-25 13:05 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919120951.GO21013@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc@cpdesign.com.au \
--cc=sameo@linux.intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®