From: Jan Kara <jack@suse.cz>
To: Mel Gorman <mgorman@suse.de>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Kent Overstreet <koverstreet@google.com>,
Jens Axboe <axboe@kernel.dk>, Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: Did immutable bvecs accidentally break stable page writes?
Date: Thu, 19 Sep 2013 16:22:38 +0200 [thread overview]
Message-ID: <20130919142238.GB20140@quack.suse.cz> (raw)
In-Reply-To: <20130919094030.GT22421@suse.de>
On Thu 19-09-13 10:40:30, Mel Gorman wrote:
> On Thu, Sep 19, 2013 at 10:32:50AM +0100, Mel Gorman wrote:
> > Commit ffecfd1a (block: optionally snapshot page contents to provide
> > stable pages during write) uses bounce buffers for stable page writes in
> > jbd and ext3. Simplistically, __blk_queue_bounce takes a force parameter
> > that is used when pages must be snapshot.
> >
> > Commit 6bc454d1 (bounce: Refactor __blk_queue_bounce to not use
> > bi_io_vec) refactored __blk_queue_bounce and now the start of the
> > function looks like this
> >
> > static void __blk_queue_bounce(struct request_queue *q, struct bio **bio_orig,
> > mempool_t *pool, int force)
> > {
> > struct bio *bio;
> > int rw = bio_data_dir(*bio_orig);
> > struct bio_vec *to, *from;
> > unsigned i;
> >
> > bio_for_each_segment(from, *bio_orig, i)
> > if (page_to_pfn(from->bv_page) > queue_bounce_pfn(q))
> > goto bounce;
> >
> > return;
> > bounce:
> > bio = bio_clone_bioset(*bio_orig, GFP_NOIO, fs_bio_set);
> >
> > bio_for_each_segment_all(to, bio, i) {
> > struct page *page = to->bv_page;
> >
> > if (page_to_pfn(page) <= queue_bounce_pfn(q) && !force)
> > continue;
> >
> > Note that the first bio_for_each_segment is completely ignoring the
> > force parameter and hence snapshotting. This is particularly problematic
> > for ext3 which forces the use of MS_SNAP_STABLE.
> >
>
> Which of course is no longer a problem for ext3 after commit 71368511
> ("mm: make snapshotting pages for stable writes a per-bio operation). The
> folly of looking at a commit in isolation! I'm still curious why the force
> parameter is ignored when stable writes are required though.
This really looks like a bug to me. Since stable pages are currently
required only for drives supporting DIF/DIX noone has likely noticed. But
still we should fix that.
Honza
PS: As an unrelated note first 8 digits of the commit SHA are not unique
for that commit. Time to switch to longer prefixes? :)
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2013-09-22 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 9:32 Mel Gorman
2013-09-19 9:40 ` Mel Gorman
2013-09-19 14:22 ` Jan Kara [this message]
2013-09-20 2:38 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130919142238.GB20140@quack.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=darrick.wong@oracle.com \
--cc=koverstreet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®