From: joerg Reisenweber <joerg@openmoko.org>
To: "Pali Rohár" <pali.rohar@gmail.com>, "Tony Lindgren" <tony@atomide.com>
Cc: Russell King <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] RX-51: Add missing max_current to rx51_lp5523_led_config
Date: Mon, 23 Sep 2013 15:06:31 +0200 [thread overview]
Message-ID: <201309231506.37942.joerg@openmoko.org> (raw)
In-Reply-To: <201309231450.12171@pali>
[-- Attachment #1: Type: Text/Plain, Size: 2664 bytes --]
On Mon 23 September 2013 14:50:12 Pali Rohár wrote:
> Hi Tony,
>
> here is new version (v2) of patch which adding max_current values to rx51
> board data. According to joerg safe value for max_current is 100 (10 mA).
>
>
> RX-51: Add missing max_current to rx51_lp5523_led_config
>
> File drivers/leds/leds-lp55xx-common.c refuse to change led_current sysfs
> attribute if value is higher than max_current specified in board file. By
> default global C variables are zero, so changing always failed. This patch
> adding missing max_current and setting it to max safe value 100 (10 mA).
>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> ---
> arch/arm/mach-omap2/board-rx51-peripherals.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-rx51-peripherals.c
> b/arch/arm/mach-omap2/board-rx51-peripherals.c index c3270c0..f6fe388
> 100644
> --- a/arch/arm/mach-omap2/board-rx51-peripherals.c
> +++ b/arch/arm/mach-omap2/board-rx51-peripherals.c
> @@ -167,38 +167,47 @@ static struct lp55xx_led_config
> rx51_lp5523_led_config[] = { .name = "lp5523:kb1",
> .chan_nr = 0,
> .led_current = 50,
> + .max_current = 100,
> }, {
> .name = "lp5523:kb2",
> .chan_nr = 1,
> .led_current = 50,
> + .max_current = 100,
> }, {
> .name = "lp5523:kb3",
> .chan_nr = 2,
> .led_current = 50,
> + .max_current = 100,
> }, {
> .name = "lp5523:kb4",
> .chan_nr = 3,
> .led_current = 50,
> + .max_current = 100,
> }, {
> .name = "lp5523:b",
> .chan_nr = 4,
> .led_current = 50,
> + .max_current = 100,
> }, {
> .name = "lp5523:g",
> .chan_nr = 5,
> .led_current = 50,
> + .max_current = 100,
> }, {
> .name = "lp5523:r",
> .chan_nr = 6,
> .led_current = 50,
> + .max_current = 100,
> }, {
> .name = "lp5523:kb5",
> .chan_nr = 7,
> .led_current = 50,
> + .max_current = 100,
> }, {
> .name = "lp5523:kb6",
> .chan_nr = 8,
> .led_current = 50,
> + .max_current = 100,
> }
> };
Reviewed and found logically and technically correct
Signed-off-by: Joerg Reisenweber <joerg AT openmoko DOT org>
/jOERG
--
() ascii ribbon campaign - against html e-mail
/\ www.asciiribbon.org - against proprietary attachments
(alas the above page got scrapped due to resignation(!!), so here some
supplementary links:)
http://www.georgedillon.com/web/html_email_is_evil.shtml
http://www.nonhtmlmail.org/campaign.html
http://www.georgedillon.com/web/html_email_is_evil_still.shtml
http://www.gerstbach.at/2004/ascii/ (German)
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2013-09-23 13:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-18 21:52 [PATCH] " Pali Rohár
2013-09-18 22:26 ` Tony Lindgren
2013-09-19 21:01 ` Pali Rohár
2013-09-19 21:29 ` Tony Lindgren
2013-09-19 22:20 ` Pali Rohár
2013-09-23 12:50 ` [PATCH v2] " Pali Rohár
2013-09-23 13:06 ` joerg Reisenweber [this message]
2013-10-08 18:29 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201309231506.37942.joerg@openmoko.org \
--to=joerg@openmoko.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pali.rohar@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome