From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: lee.jones@linaro.org, sameo@linux.intel.com,
rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, rob@landley.net,
patches@opensource.wolfsonmicro.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] mfd: arizona: Add micdet ranges and polarity device tree bindings
Date: Mon, 23 Sep 2013 23:25:03 +0100 [thread overview]
Message-ID: <20130923222503.GJ21013@sirena.org.uk> (raw)
In-Reply-To: <1379961043-23762-4-git-send-email-ckeepax@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 1207 bytes --]
On Mon, Sep 23, 2013 at 07:30:42PM +0100, Charles Keepax wrote:
> Documentation/devicetree/bindings/mfd/arizona.txt | 26 +++++
> drivers/mfd/arizona-core.c | 116 +++++++++++++++++++++
It's probably more idomatic to put the parsing for these in the driver
that uses them.
> + - wlf,micd-ranges : Microphone detection level and key configuration, this
> + field can be of variable length but should always be a multiple of 2 cells
> + long, each two cell group represents one button configuration
> + The first cell is the maximum impedance for this button in ohms
> + The second cell the key that should be reported to the input layer
This isn't good - the device tree is supposed to be an OS independant
description of the hardware that can be used by any OS but this binding
embeds Linux-specific numbers. There are a few Linux specific bindings
where people have just given up due to the complexity of developing a
generic description but this doesn't seem like it shuld be such a case.
This is going to be used for buttons on headsets and essentially all
real headsets can be covered by just defining the ability to set hook
switch, fast forward and rewind.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-23 22:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 18:30 [PATCH 1/5] mfd: arizona: Add device tree helper functions Charles Keepax
2013-09-23 18:30 ` [PATCH 2/5] mfd: arizona: Add device tree binding for max_channels_clocked Charles Keepax
2013-09-23 21:38 ` Stephen Warren
2013-09-23 23:28 ` Mark Brown
2013-09-24 9:58 ` Charles Keepax
2013-09-23 18:30 ` [PATCH 3/5] mfd: arizona: Add simple microphone detection device tree bindings Charles Keepax
2013-09-23 18:30 ` [PATCH 4/5] mfd: arizona: Add micdet ranges and polarity " Charles Keepax
2013-09-23 21:41 ` Stephen Warren
2013-09-23 22:25 ` Mark Brown [this message]
2013-09-23 18:30 ` [PATCH 5/5] mfd: arizona: Add device tree bindings for MICBIAS generators Charles Keepax
2013-09-23 21:43 ` Stephen Warren
2013-09-23 22:27 ` Mark Brown
2013-09-23 21:36 ` [PATCH 1/5] mfd: arizona: Add device tree helper functions Stephen Warren
2013-09-24 9:49 ` Charles Keepax
2013-09-24 10:20 ` Mark Brown
2013-09-24 22:58 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923222503.GJ21013@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=devicetree@vger.kernel.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=sameo@linux.intel.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®