From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751508Ab3IXIch (ORCPT ); Tue, 24 Sep 2013 04:32:37 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:7834 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750823Ab3IXIcd (ORCPT ); Tue, 24 Sep 2013 04:32:33 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 24 Sep 2013 01:28:58 -0700 Date: Tue, 24 Sep 2013 11:32:31 +0300 From: Peter De Schrijver To: Stephen Warren CC: Mike Turquette , Prashant Gaikwad , Thierry Reding , Joseph Lo , Paul Walmsley , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-tegra@vger.kernel.org" Subject: Re: [PATCH 10/12] clk: tegra: move fixed clocks to common file Message-ID: <20130924083231.GK30013@tbergstrom-lnx.Nvidia.com> References: <1379515331-19427-1-git-send-email-pdeschrijver@nvidia.com> <1379515331-19427-11-git-send-email-pdeschrijver@nvidia.com> <524089C8.4010108@wwwdotorg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <524089C8.4010108@wwwdotorg.org> X-NVConfidentiality: public User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 23, 2013 at 08:34:48PM +0200, Stephen Warren wrote: > On 09/18/2013 08:41 AM, Peter De Schrijver wrote: > > Introduce a new file for fixed clocks common between several Tegra > > SoCs and move Tegra114 to this new infrastructure. > > > diff --git a/drivers/clk/tegra/clk-tegra-fixed.c b/drivers/clk/tegra/clk-tegra-fixed.c > > > +void __init tegra_fixed_clk_init(struct tegra_clk *tegra_clks) > > > + /* clk_m_div2 */ > > + dt_clk = tegra_lookup_dt_id(tegra_clk_clk_m_div2, tegra_clks); > > + if (dt_clk) { > > + clk = clk_register_fixed_factor(NULL, "clk_m_div2", "clk_m", > > + CLK_SET_RATE_PARENT, 1, 2); > > + clk_register_clkdev(clk, "clk_m_div2", NULL); > > + *dt_clk = clk; > > + } > > I guess "fixed" means "fixed at run-time", not "identical rate in all > systems"? Since this is the crystal rate, it can vary between boards, > but I supposed if "fixed" means "fixed at run-time", considering this as > a fixed clock is fine. > Fixed means "fixed at run-time" indeed. Although clk_32k is 32768Hz on all boards as well. > But, isn't clk_m also a fixed clock then? I would expect one or two more I guess the code from clk-tegra-osc.c could be moved here if you think that's better? > clocks in this file. What about clk_s, or is that known as clk_32k here? I don't think we ever had clk_s in upstream? Cheers, Peter.