From: Will Deacon <will.deacon@arm.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: "grant.likely@linaro.org" <grant.likely@linaro.org>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
"nico@linaro.org" <nico@linaro.org>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
"dave.martin@linaro.org" <dave.martin@linaro.org>,
Sudeep KarkadaNagesha <Sudeep.KarkadaNagesha@arm.com>,
"yongjun_wei@trendmicro.com.cn" <yongjun_wei@trendmicro.com.cn>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH -next] drivers: CCI: fix the error handle in cci_pmu_probe()
Date: Tue, 24 Sep 2013 10:32:22 +0100 [thread overview]
Message-ID: <20130924093222.GC15119@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <CAPgLHd9jKOp71tN43=oOUN4X_niTonuQExO1yMSy=3odoRqTcQ@mail.gmail.com>
On Sun, Sep 22, 2013 at 06:04:23AM +0100, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> This patch fix the error handle of function cci_pmu_probe():
> - using IS_ERR() instead of NULL test for the return value of
> devm_ioremap_resource() since it nerver return NULL.
> - remove kfree() for devm_kzalloc allocated memory
> - remove dev_warn() since devm_ioremap_resource() has error message
> already.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Cheers Wei, I'll add this as a new patch on top of my perf branch.
Will
prev parent reply other threads:[~2013-09-24 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 5:04 Wei Yongjun
2013-09-24 9:32 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130924093222.GC15119@mudshark.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Sudeep.KarkadaNagesha@arm.com \
--cc=dave.martin@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nico@linaro.org \
--cc=rob.herring@calxeda.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®