From: Simon Horman <horms@verge.net.au>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Vinod Koul <vinod.koul@intel.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Subject: Re: [PATCH v5 6/7] ARM: shmobile: r8a73a4: add a DT node and a clock alias for the DMAC
Date: Wed, 25 Sep 2013 17:01:29 +0900 [thread overview]
Message-ID: <20130925080129.GB3747@verge.net.au> (raw)
In-Reply-To: <1375455042-24093-7-git-send-email-g.liakhovetski@gmx.de>
On Fri, Aug 02, 2013 at 04:50:41PM +0200, Guennadi Liakhovetski wrote:
> Add a DT node for the only system DMAC instance on r8a73a4. The RT DMAC
> can be added later under the same multiplexer, because they can serve the
> same slaves and use the same MID-RID values. Configuration data is
> supplied to the driver, using a compatibility match string.
Hi Guennadi,
please split this up into two patches.
A DT patch that modifies r8a73a4.dtsi and an SoC patch that modifies
clock-r8a73a4.c.
Thanks.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> ---
> arch/arm/boot/dts/r8a73a4.dtsi | 43 ++++++++++++++++++++++++++++++++
> arch/arm/mach-shmobile/clock-r8a73a4.c | 1 +
> 2 files changed, 44 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/r8a73a4.dtsi b/arch/arm/boot/dts/r8a73a4.dtsi
> index e344b10..3c9c7f2 100644
> --- a/arch/arm/boot/dts/r8a73a4.dtsi
> +++ b/arch/arm/boot/dts/r8a73a4.dtsi
> @@ -78,6 +78,49 @@
> <0 56 4>, <0 57 4>;
> };
>
> + dmac: dma-multiplexer@0 {
> + compatible = "renesas,shdma-mux";
> + #dma-cells = <1>;
> + dma-channels = <20>;
> + dma-requests = <256>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> +
> + dma0: dma-controller@e6700020 {
> + compatible = "renesas,shdma-r8a73a4";
> + reg = <0 0xe6700020 0 0x89e0>;
> + interrupt-parent = <&gic>;
> + interrupts = <0 220 4
> + 0 200 4
> + 0 201 4
> + 0 202 4
> + 0 203 4
> + 0 204 4
> + 0 205 4
> + 0 206 4
> + 0 207 4
> + 0 208 4
> + 0 209 4
> + 0 210 4
> + 0 211 4
> + 0 212 4
> + 0 213 4
> + 0 214 4
> + 0 215 4
> + 0 216 4
> + 0 217 4
> + 0 218 4
> + 0 219 4>;
> + interrupt-names = "error",
> + "ch0", "ch1", "ch2", "ch3",
> + "ch4", "ch5", "ch6", "ch7",
> + "ch8", "ch9", "ch10", "ch11",
> + "ch12", "ch13", "ch14", "ch15",
> + "ch16", "ch17", "ch18", "ch19";
> + };
> + };
> +
> thermal@e61f0000 {
> compatible = "renesas,rcar-thermal";
> reg = <0 0xe61f0000 0 0x14>, <0 0xe61f0100 0 0x38>,
> diff --git a/arch/arm/mach-shmobile/clock-r8a73a4.c b/arch/arm/mach-shmobile/clock-r8a73a4.c
> index 357b9bc..74841ed 100644
> --- a/arch/arm/mach-shmobile/clock-r8a73a4.c
> +++ b/arch/arm/mach-shmobile/clock-r8a73a4.c
> @@ -580,6 +580,7 @@ static struct clk_lookup lookups[] = {
> CLKDEV_DEV_ID("sh-sci.4", &mstp_clks[MSTP216]),
> CLKDEV_DEV_ID("sh-sci.5", &mstp_clks[MSTP217]),
> CLKDEV_DEV_ID("sh-dma-engine.0", &mstp_clks[MSTP218]),
> + CLKDEV_DEV_ID("e6700020.dma-controller", &mstp_clks[MSTP218]),
> CLKDEV_DEV_ID("rcar_thermal", &mstp_clks[MSTP522]),
> CLKDEV_DEV_ID("e6520000.i2c", &mstp_clks[MSTP300]),
> CLKDEV_DEV_ID("sh_mmcif.1", &mstp_clks[MSTP305]),
> --
> 1.7.2.5
>
next prev parent reply other threads:[~2013-09-25 8:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 14:50 [PATCH v5 0/7] DMA: shdma: switch DT to use OF device ID tables Guennadi Liakhovetski
2013-08-02 14:50 ` [PATCH v5 1/7] DMA: shdma: switch DT mode to use configuration data from a match table Guennadi Liakhovetski
2013-08-02 14:50 ` [PATCH v5 2/7] DMA: shdma: remove private and unused defines from a global header Guennadi Liakhovetski
2013-08-02 14:50 ` [PATCH v5 3/7] DMA: shdma: add a header with common for ARM SoCs defines Guennadi Liakhovetski
2013-08-02 14:50 ` [PATCH v5 4/7] DMA: shdma: add r8a73a4 DMAC data to the device ID table Guennadi Liakhovetski
2013-08-02 14:50 ` [PATCH v5 5/7] ARM: shmobile: r8a73a4: add a DMAC platform device and clock for it Guennadi Liakhovetski
2013-09-25 5:50 ` Simon Horman
2013-09-25 6:52 ` Guennadi Liakhovetski
2013-09-25 7:10 ` Simon Horman
2013-09-25 7:22 ` Guennadi Liakhovetski
2013-08-02 14:50 ` [PATCH v5 6/7] ARM: shmobile: r8a73a4: add a DT node and a clock alias for the DMAC Guennadi Liakhovetski
2013-09-25 5:53 ` Simon Horman
2013-09-25 8:01 ` Simon Horman [this message]
2013-08-02 14:50 ` [PATCH v5 7/7] ARM: shmobile: ape6evm-reference: enable DMA for the MMC interface Guennadi Liakhovetski
2013-09-25 5:54 ` Simon Horman
2013-09-25 7:56 ` Simon Horman
2013-09-25 8:07 ` Simon Horman
2013-08-25 7:36 ` [PATCH v5 0/7] DMA: shdma: switch DT to use OF device ID tables Vinod Koul
2013-08-26 7:17 ` Simon Horman
2013-08-26 7:49 ` Vinod Koul
2013-08-26 8:46 ` Simon Horman
2013-08-29 11:24 ` Guennadi Liakhovetski
2013-09-04 8:55 ` Simon Horman
2013-09-25 7:12 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925080129.GB3747@verge.net.au \
--to=horms@verge.net.au \
--cc=g.liakhovetski+renesas@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®