From: Lee Jones <lee.jones@linaro.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Wei Yongjun <weiyj.lk@gmail.com>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
yongjun_wei@trendmicro.com.cn,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: twl6040: drop devm_free_irq of devm_ allocated irq
Date: Wed, 25 Sep 2013 11:28:25 +0100 [thread overview]
Message-ID: <20130925102825.GE5132@lee--X1> (raw)
In-Reply-To: <CAK9yfHxo=zWxvH2KoUiMfys5MXfkJiCcF3L7yO_zHTOq5dm9qg@mail.gmail.com>
On Wed, 25 Sep 2013, Sachin Kamat wrote:
> On 25 September 2013 13:07, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> > From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> >
> > - devm_free_irq(&client->dev, twl6040->irq_ready, twl6040);
> > - devm_free_irq(&client->dev, twl6040->irq_th, twl6040);
> > regmap_del_irq_chip(twl6040->irq, twl6040->irq_data);
>
> Now that the freeing of irq will happen after regmap_del_irq_chip,
> wouldn't this cause any ordering related issues?
I don't believe there is a requirement to free all associated IRQs
before deleting an irqchip.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2013-09-25 10:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 7:37 Wei Yongjun
2013-09-25 10:08 ` Lee Jones
2013-09-25 10:10 ` Sachin Kamat
2013-09-25 10:28 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925102825.GE5132@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=sameo@linux.intel.com \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®