From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Oussama Ghorbel <oghorbell@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IPv6: Allow the MTU of ipip6 tunnel to be set below 1280
Date: Fri, 27 Sep 2013 12:58:56 +0200 [thread overview]
Message-ID: <20130927105856.GF28287@order.stressinduktion.org> (raw)
In-Reply-To: <CA+ev270=P9txSvo7AZN0YcsopwhCYtJCgcZCPsdofEJ+BX+EUQ@mail.gmail.com>
On Fri, Sep 27, 2013 at 11:45:48AM +0100, Oussama Ghorbel wrote:
> The ip6_tunnel.c module would be then dependent on ip_tunnel.c and may
> be it would not be good thing?
It could just be a static inline in some shared header. So there would
be no compile-time dependency.
> As I have check in v3.10 there is no call from ip6_tunnel to ip_tunnel...
>
> For information, there is no check for the maximum MTU for ipv4 in the
> patch as this is not done for ipv6.
I understand, but it would be better to limit the MTU here. There is a
(non-jumo) IPV6_MAXPLEN constant.
Looking through the source it seems grev6 does actually check this,
so it would not hurt adding them here, too.
Otherwise, I think your patch is fine.
Greetings,
Hannes
next prev parent reply other threads:[~2013-09-27 10:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 14:51 Oussama Ghorbel
2013-09-27 8:37 ` Hannes Frederic Sowa
2013-09-27 10:45 ` Oussama Ghorbel
2013-09-27 10:58 ` Hannes Frederic Sowa [this message]
2013-09-27 16:36 ` Oussama Ghorbel
2013-09-27 17:03 ` Hannes Frederic Sowa
2013-09-29 9:40 ` Oussama Ghorbel
2013-09-29 15:45 ` Hannes Frederic Sowa
2013-09-29 16:33 ` Oussama Ghorbel
2013-10-03 12:37 ` Oussama Ghorbel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927105856.GF28287@order.stressinduktion.org \
--to=hannes@stressinduktion.org \
--cc=davem@davemloft.net \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oghorbell@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®