mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: hpa@zytor.com, linux-kernel@vger.kernel.org,
	huawei.libin@huawei.com, wangyijing@huawei.com,
	fenghua.yu@intel.com, tglx@linutronix.de, guohanjun@huawei.com,
	paul.gortmaker@windriver.com, linux-tip-commits@vger.kernel.org
Subject: Re: [PATCH 2/2] x86: Cleanup boot CPUs table
Date: Sat, 28 Sep 2013 15:44:49 +0200	[thread overview]
Message-ID: <20130928134449.GB26931@gmail.com> (raw)
In-Reply-To: <20130928102305.GA5956@pd.tnic>


* Borislav Petkov <bp@alien8.de> wrote:

> On Sat, Sep 28, 2013 at 10:25:42AM +0200, Ingo Molnar wrote:
> > Could we, with another add-on patch, further compress the first half
> > of the output as well?
> >
> > Advanced output like this would be really cool:
> 
> Sure.
> 
> > > [    0.074509] x86: Booting node #0, CPUs:       #1  #2  #3  #4  #5  #6  #7
> > > [    0.644008] x86: Booting node #1, CPUs:   #8  #9 #10 #11 #12 #13 #14 #15
> > > [    1.245006] x86: Booting node #2, CPUs:  #16 #17 #18 #19 #20 #21 #22 #23
> > > [    1.864005] x86: Booting node #3, CPUs:  #24 #25 #26 #27 #28 #29 #30 #31
> > > [    2.489005] x86: Booting node #4, CPUs:  #32 #33 #34 #35 #36 #37 #38 #39
> > > [    3.093005] x86: Booting node #5, CPUs:  #40 #41 #42 #43 #44 #45 #46 #47
> > > [    3.698005] x86: Booting node #6, CPUs:  #48 #49 #50 #51 #52 #53 #54 #55
> > > [    4.304005] x86: Booting node #7, CPUs:  #56 #57 #58 #59 #60 #61 #62 #63
> > > [    4.961413] x86: Booted up 8 nodes, 64 CPUs
> 
> Boot(ing|ed) kinda wastes unnecessary space too, how about we go a step
> further:
> 
> [    0.074509] x86: Booting SMP configuration:
> [    0.644008] .... node #0, CPUs:       #1  #2  #3  #4  #5  #6  #7
> [    1.245006] .... node #1, CPUs:   #8  #9 #10 #11 #12 #13 #14 #15
> [    1.864005] .... node #2, CPUs:  #16 #17 #18 #19 #20 #21 #22 #23
> [    2.489005] .... node #3, CPUs:  #24 #25 #26 #27 #28 #29 #30 #31
> [    3.093005] .... node #4, CPUs:  #32 #33 #34 #35 #36 #37 #38 #39
> [    3.698005] .... node #5, CPUs:  #40 #41 #42 #43 #44 #45 #46 #47
> [    4.304005] .... node #6, CPUs:  #48 #49 #50 #51 #52 #53 #54 #55
> [    4.961413] .... node #7, CPUs:  #56 #57 #58 #59 #60 #61 #62 #63
> [    5.245021] x86: Booted up 8 nodes, 64 CPUs
>
> 
> [    0.074509] x86: Booting SMP configuration:
> [    0.072367] .... node #0, CPUs:     #1 #2 #3 #4 #5 #6 #7
> [    0.686329] x86: Booted up 1 node, 8 CPUs

Nice!

> Btw, the "x86" prefix would mean we want to either change pr_fmt() of
> arch/x86/kernel/smpboot.c (which I rather not) or not use pr_info (which
> I'd prefer).

Not using pr_info() for such specially formatted output is fine I think.

Thanks,

	Ingo

  reply	other threads:[~2013-09-28 13:44 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 10:57 [PATCH] x86, smpboot: fix announce_cpu() to print the last OK Libin
2013-09-05 17:52 ` [tip:x86/urgent] x86/smpboot: Fix announce_cpu() to printk() the last "OK" properly tip-bot for Libin
2013-09-25 10:07   ` Borislav Petkov
2013-09-25 18:29     ` Ingo Molnar
2013-09-26 23:15       ` Borislav Petkov
2013-09-27  6:51         ` Ingo Molnar
2013-09-27 10:38           ` Borislav Petkov
2013-09-27 14:32             ` Borislav Petkov
2013-09-27 14:34               ` [PATCH 1/2] x86, alternatives: Drop ancient lockdep fixup message Borislav Petkov
2013-09-28  8:28                 ` [tip:core/locking] lockdep, x86/alternatives: " tip-bot for Borislav Petkov
2013-09-27 14:35               ` [PATCH 2/2] x86: Cleanup boot CPUs table Borislav Petkov
2013-09-28  8:25                 ` Ingo Molnar
2013-09-28 10:23                   ` Borislav Petkov
2013-09-28 13:44                     ` Ingo Molnar [this message]
2013-09-28 17:47                       ` [PATCH] x86, boot: Further compress CPUs bootup message Borislav Petkov
2013-09-28 17:54                         ` Ingo Molnar
2013-09-28 18:04                           ` [PATCH -v1.1] " Borislav Petkov
2013-09-28 18:12                             ` Ingo Molnar
2013-09-28 19:15                               ` Borislav Petkov
2013-09-28 19:25                                 ` Ingo Molnar
2013-09-28 19:36                                   ` [PATCH -v1.3] " Borislav Petkov
2013-09-28 19:42                                   ` [PATCH -v1.1] " H. Peter Anvin
2013-09-28 19:49                                     ` Borislav Petkov
2013-09-28 19:54                                       ` Borislav Petkov
2013-09-28 19:58                                         ` Ingo Molnar
2013-09-28 20:08                                           ` Borislav Petkov
2013-09-28 23:13                                             ` H. Peter Anvin
2013-09-29  9:14                                               ` Borislav Petkov
2013-09-29 15:17                                                 ` [PATCH -v1.4] " Borislav Petkov
2013-09-29 15:44                                                 ` [PATCH -v1.1] " H. Peter Anvin
2013-09-30  6:28                                                   ` Ingo Molnar
2013-09-30  9:56                                                     ` Borislav Petkov
2013-10-01  8:53                                                       ` Ingo Molnar
2013-10-01  9:10                                                       ` [tip:x86/boot] x86/boot: " tip-bot for Borislav Petkov
2013-10-02 11:52                                                         ` Peter Zijlstra
2013-10-02 12:18                                                           ` Ingo Molnar
2013-10-02 12:20                                                           ` Peter Zijlstra
2013-10-02 13:55                                                             ` Borislav Petkov
2013-09-28 19:58                                     ` [PATCH -v1.1] x86, boot: " Ingo Molnar
2013-09-28 20:10                                       ` Borislav Petkov
2013-09-29  5:10                                         ` H. Peter Anvin
2013-09-29  2:55                   ` [PATCH 2/2] x86: Cleanup boot CPUs table Mike Galbraith
2013-09-28  8:28                 ` [tip:x86/boot] x86: Improve the printout of the SMP bootup CPU table tip-bot for Borislav Petkov
2013-09-29  4:25                   ` Yinghai Lu
2013-09-27 12:48           ` [tip:x86/urgent] x86/smpboot: Fix announce_cpu() to printk() the last "OK" properly Borislav Petkov
2013-09-27 13:33             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130928134449.GB26931@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=fenghua.yu@intel.com \
    --cc=guohanjun@huawei.com \
    --cc=hpa@zytor.com \
    --cc=huawei.libin@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=tglx@linutronix.de \
    --cc=wangyijing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome