From: David Miller <davem@davemloft.net>
To: b.zolnierkie@samsung.com
Cc: jonas.jensen@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kyungmin.park@samsung.com
Subject: Re: [PATCH] ethernet: moxa: fix incorrect placement of __initdata tag
Date: Mon, 30 Sep 2013 22:17:31 -0700 (PDT) [thread overview]
Message-ID: <20130930.221731.1527688326511547313.davem@davemloft.net> (raw)
In-Reply-To: <172588984.DhoE4BmVdc@amdc1032>
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Date: Mon, 30 Sep 2013 15:18:27 +0200
> __initdata tag should be placed between the variable name and equal
> sign for the variable to be placed in the intended .init.data section.
>
> In this particular case __initdata is incorrect as moxart_mac_driver
> can be used after the driver gets initialized.
>
> Also while at it static-ize moxart_mac_driver.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Applied, thanks.
prev parent reply other threads:[~2013-10-01 5:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 13:18 Bartlomiej Zolnierkiewicz
2013-10-01 5:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930.221731.1527688326511547313.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=b.zolnierkie@samsung.com \
--cc=jonas.jensen@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®